1092549 - Sometimes, the new inputcontext is broken if input focus moved from chrome back to app process

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

STR
0. Apply patch of bug 1079748
1. Open message app and write a new message, focus the contact input. Keyboard will show up.
2. Open rocketbar from the left side of title area.
3. Type something.
4. Click close button of rocketbar.

Actual
The keyboard will stay when rocketbar is closed,
but when you click keyboard nothing is shown in the input.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Let me take a look on Monday then.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can verify this is an API issue; the keyboard was given an inputcontext pointing to the right textarea but all methods (sendKey() etc) rejects with "InputContext has expired" error.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Here is the log I collected. The root cause of this bug is because formMM was being reset to the previous focused element when focus changed. The fix required will be very similar to bug 1083617.

I/Gecko   ( 6713): XXXXX MozKeyboard.js inputcontext {"contextId":15,"type":"search","choices":null,"value":"","inputmode":"verbatim","selectionStart":0,"selectionEnd":0,"max":"","min":"","lang":"","textBeforeCursor":"","textAfterCursor":""}
I/Gecko   ( 6375): XXXXX 703 fa_unhandleFocusSync
I/Gecko   ( 6375): XXXXX 710 blur
I/Gecko   ( 6713): XXXXX MozKeyboard.js inputcontext null
I/Gecko   ( 6828): XXXXX 685 fa_handleFocusSync
I/Gecko   ( 6828): XXXXX 690 focus true
I/Gecko   ( 6375): XXXXX 476 SequenceError
I/Gecko   ( 6375): XXXXX forwardEvent w/ new MM: Keyboard:FocusChange{"target":{},"name":"Forms:Input","sync":false,"json":{"contextId":25,"type":"textarea","choices":null,"value":"cfnn","inputmode":"verbatim","selectionStart":4,"selectionEnd":4,"max":"","min":"","lang":"","textBeforeCursor":"cfnn","textAfterCursor":""},"data":{"contextId":25,"type":"textarea","choices":null,"value":"cfnn","inputmode":"verbatim","selectionStart":4,"selectionEnd":4,"max":"","min":"","lang":"","textBeforeCursor":"cfnn","textAfterCursor":""},"objects":{}}
I/Gecko   ( 6713): XXXXX MozKeyboard.js inputcontext {"contextId":25,"type":"textarea","choices":null,"value":"cfnn","inputmode":"verbatim","selectionStart":4,"selectionEnd":4,"max":"","min":"","lang":"","textBeforeCursor":"cfnn","textAfterCursor":""}
I/Gecko   ( 6375): XXXXX forwardEvent w/ new MM: Keyboard:SequenceError{"target":{},"name":"Forms:SequenceError","sync":false,"json":{"requestId":"id{89258bd5-5411-4dff-ba22-ec5aa4a37642}","error":"Expected contextId 16 but was 15"},"data":{"requestId":"id{89258bd5-5411-4dff-ba22-ec5aa4a37642}","error":"Expected contextId 16 but was 15"},"objects":{}}
I/Gecko   ( 6375): XXXXX 476 SequenceError
I/Gecko   ( 6713): XXXXX SequenceError: Expected contextId 16 but was 25
I/Gecko   ( 6375): XXXXX 476 SequenceError
I/Gecko   ( 6713): XXXXX SequenceError: Expected contextId 16 but was 25
I/Gecko   ( 6375): XXXXX 476 SequenceError
I/Gecko   ( 6713): XXXXX SequenceError: Expected contextId 16 but was 25

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch v1.0

This patch further limit the message capable of changing the formMM to the real focus message only. Again because of bug 1090032 I can't write any test for this.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=415c534deb57

Comment 5

[Yuan Xulei [:yxl] (Leave from May 18)]

Comment on attachment 8515802 [details] [diff] [review]
Patch v1.0

Review of attachment 8515802 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/inputmethod/Keyboard.jsm
@@ +257,5 @@
> +        // message gets to the right form now on.
> +        this.formMM = mm;
> +      } else { // input is blurred
> +        // A blur message can't be sent to the keyboard if the focus has
> +        // already taken away at first place.

nit: been taken away

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for commit

Let's wait for try to finish before checkin-needed.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd0146aeb963

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd0146aeb963