1092573 - Adding Latvian (lv) to Firefox OS builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[JM Gailis [:jm-gailis]]

This is to merge a patch which includes Latvian (lv) to the Firefox OS builds.

Comment 1

[JM Gailis [:jm-gailis]]

Merge request on Github: https://github.com/mozilla-b2g/gaia/pull/25720

Comment 2

[JM Gailis [:jm-gailis]]

Attachment: Patch to include Latvian (lv) in languages_all.json

Comment 3

[Raivis Dejus]

Comment on attachment 8515492 [details] [review]
Patch to include Latvian (lv) in languages_all.json

I think we should add Latvian gaia to the nightly/aurora builds so that people can see translations in real life and test them, catch the bugs and fix them.

Comment 4

[Théo Chevalier]

It can definitely be added to master (Nightly), but right now I don't feel it can be added to 2.1 builds (Aurora) for the following reasons:

- we don't have any lv repo for 2.1 https://hg.mozilla.org/releases/gaia-l10n/v2_1/
- working on 2.1 would require lv localizers to maintain and push to two repositories, make uplifts, etc. Fixing bugs on several branches is painful
- 2.1 l10n is supposed be be wrapped up since October 30th
- uplifting the patch attached to this bug to 2.1 branch would require it to block the 2.1 release

Comment 5

[Staś Małolepszy :stas]

Comment on attachment 8515492 [details] [review]
Patch to include Latvian (lv) in languages_all.json

Can you also add lv to https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json as per https://wiki.mozilla.org/L10n:B2G/Adding_Locales#Add_to_Gaia please?

Comment 6

[Raivis Dejus]

Comment on attachment 8515492 [details] [review]
Patch to include Latvian (lv) in languages_all.json

It is ok, to add lv to only nightly. We will test everything there at first

Comment 7

[JM Gailis [:jm-gailis]]

Created pull request to update mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json :
https://github.com/mozilla-b2g/gaia/pull/26377

Comment 8

[JM Gailis [:jm-gailis]]

Attachment: Patch to include Latvian (lv) in keyboard-layouts.json

Comment 9

[Staś Małolepszy :stas]

This looks good, thanks Jānis!  Would you mind combining both changes into a single pull request?

Comment 10

[JM Gailis [:jm-gailis]]

Attachment: Patch to include Latvian (lv) in keyboard-layouts.json and languages_all.json

Is this ok?

Comment 11

[Staś Małolepszy :stas]

Comment on attachment 8527171 [details] [review]
Patch to include Latvian (lv) in keyboard-layouts.json and languages_all.json

r=me, thanks!

Comment 12

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/2c15b8d12d5db60709278547327f23fbd77bedaa