1092702 - Logviewer: Logviewer angular templates flicker on page load

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Jonathan French (:jfrench)]

A small polish-thing - at least on my (slow) machine, I observe a mildly annoying flash of the angular run-data templates during page load. I will attach a screen grab.

To reproduce
o click on any job
o click on the logviewer icon in the job panel

I think I have a working fix already which at least cleans up the angular stuff, I just want to do a bit more testing to be sure it's working properly on both browsers.

Comment 1

[Jonathan French (:jfrench)]

Attachment: logviewerPageLoad

Comment 2

[Ed Morley [:emorley]]

Yeah I see this too, doesn't look ideal from a "hey use this new treeherder thing, it's reliable, tested & polished... honest" POV :-)

Comment 3

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#258

Please see the above PR for review and status.

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/258448b02421f13b03845b2ed682bac6437249f5
Bug 1092702 - Fix logviewer angular template flicker on page load

https://github.com/mozilla/treeherder-ui/commit/3baad207a7d7189de270f1815bc329d9a9cccff7
Merge pull request #258 from tojonmz/fix-logviewer-flicker

Bug 1092702 - Fix logviewer angular template flicker on page load

Comment 5

[Jonathan French (:jfrench)]

Verified fixed and working correctly on stage.

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/54271bde83598c7a28b5f8d07def2f9bc6281264
Bug 1092702 - Fix logviewer angular template flicker on page load

https://github.com/mozilla/treeherder/commit/5538ec155ae2f71c77dcc0d3b2699b45055f0680
Merge pull request #258 from tojonmz/fix-logviewer-flicker

Bug 1092702 - Fix logviewer angular template flicker on page load