Closed
Bug 1092710
Opened 10 years ago
Closed 10 years ago
Fix -Wunused-const-variable warning-as-error in non-unified security/certverifier
Categories
(Core :: Security: PSM, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.39 KB,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
When building in non-unified mode, clang reports the following warning (and treats it as an error because security/certverifier/moz.build has FAIL_ON_WARNINGS):
security/certverifier/ExtendedValidation.cpp:93:21: error: unused variable 'NUM_TEST_EV_ROOTS' [-Werror,-Wunused-const-variable]
Attachment #8515575 -
Flags: review?(dkeeler)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8515575 [details] [diff] [review]
ExtendedValidation_Wunused-const-variable.patch
Review of attachment 8515575 [details] [diff] [review]:
-----------------------------------------------------------------
Good call. Thanks for the patch.
Attachment #8515575 -
Flags: review?(dkeeler) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
status-firefox35:
--- → wontfix
status-firefox36:
--- → fixed
|
||
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•