1092860 - [EME] Some GMP enums aren't IPDL serialized correctly

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I discovered that the GMPSessionType and GMPVideoFrameType enums aren't serialized properly in GMPMessageUtils.h. The enums must have a "last/invalid value" as the last member the enum, as the IPCMessageUtils.h ContiguousEnumValidator just checks to see if the enum value being serialized is < HighBound. So if we don't have a "last/invalid" member of the GMPSessionType and GMPVideoFrameType enums and we don't pass that to the ContiguousEnumSerializer's for these enums, they won't serialize properly.

This bug was manifesting as MediaKeySession.remove() not being proxied across to the child process.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Fix the serialization of GMPVideoFrameType and GMPSessionType.

If OpenH264 relies on the kGMPSkipFrame GMPVideoFrameType value serializing correctly, we'd better uplift the GMPVideoFrameType serialization fix. Enum values < kGMPSkipFrame will still serialize correctly.

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef550ec1517a

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ef550ec1517a

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.