Closed
Bug 1092897
Opened 10 years ago
Closed 10 years ago
[BrowserMixin] Switch all browser API from DOMRequest to .then format
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: alive, Assigned: alive)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Support then with backward compatibility.
Attachment #8515805 -
Flags: review?(timdream)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8515805 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25751
Not entirely sure the complexity is warranted -- but it we need this we should land it.
Attachment #8515805 -
Flags: review?(timdream) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> Comment on attachment 8515805 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/25751
>
> Not entirely sure the complexity is warranted -- but it we need this we
> should land it.
According to Kanru, they tend to replace DOMRequest with Promise in bug 1044736, so this is a safe migration before that happens.
|
|
||
Comment 5•10 years ago
|
||
I actually meant to ask do we need to maintain backward compatibility (the onsuccess/onerror part) now the that both DOMRequest and Promise are then-able....
Flags: needinfo?(alive)
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5)
> I actually meant to ask do we need to maintain backward compatibility (the
> onsuccess/onerror part) now the that both DOMRequest and Promise are
> then-able....
Just don't want to frustrate who is working on gaia master to force them to flash latest gecko.
But if you think it's redundant, we could drop the backward compatibility.
Flags: needinfo?(alive)
|
|
||
Comment 7•10 years ago
|
||
Let's file a follow-up and remove it. It's been 3 weeks since bug 839838 lands IMHO the grace period is enough. Thanks!
Flags: needinfo?(alive)
|
|
||
Comment 8•10 years ago
|
||
FWIW I plan to use then syntax only in bug 1094561 very soon. Gaia + Gecko mismatch will be broken by then.
|
|
||
Updated•10 years ago
|
Assignee: nobody → alive
Target Milestone: --- → 2.1 S8 (7Nov)
|
|
Assignee | |
Comment 9•10 years ago
|
||
filed 1094742
|
|
Assignee | |
Updated•10 years ago
|
Flags: needinfo?(alive)
You need to log in
before you can comment on or make changes to this bug.
Description
•