1092897 - [BrowserMixin] Switch all browser API from DOMRequest to .then format

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/25751

Support then with backward compatibility.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8515805 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/25751

Not entirely sure the complexity is warranted -- but it we need this we should land it.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/c2cf0eb9e7e81e2ae6bcf897e6d35ec10103adcb

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #2)
> Comment on attachment 8515805 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/25751
> 
> Not entirely sure the complexity is warranted -- but it we need this we
> should land it.

According to Kanru, they tend to replace DOMRequest with Promise in bug 1044736, so this is a safe migration before that happens.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I actually meant to ask do we need to maintain backward compatibility (the onsuccess/onerror part) now the that both DOMRequest and Promise are then-able....

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #5)
> I actually meant to ask do we need to maintain backward compatibility (the
> onsuccess/onerror part) now the that both DOMRequest and Promise are
> then-able....

Just don't want to frustrate who is working on gaia master to force them to flash latest gecko.
But if you think it's redundant, we could drop the backward compatibility.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Let's file a follow-up and remove it. It's been 3 weeks since bug 839838 lands IMHO the grace period is enough. Thanks!

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

FWIW I plan to use then syntax only in bug 1094561 very soon. Gaia + Gecko mismatch will be broken by then.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

filed 1094742