Firefox Hello header is misaligned

VERIFIED FIXED

Status

Firefox OS
Gaia::Loop
VERIFIED FIXED
4 years ago
2 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][not blocking][tef-triage][loop not in 1.1] )

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Regression from bug 1092105
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Depends on: 1092105
Whiteboard: [mobile app]
(Assignee)

Updated

4 years ago
Blocks: 1036490
(Assignee)

Comment 1

4 years ago
Created attachment 8515819 [details]
Github pull request
Attachment #8515819 - Flags: review?(josea.olivera)
Comment on attachment 8515819 [details]
Github pull request

LGTM. r=me

Good catch. Thanks Cristian!
Attachment #8515819 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 3

4 years ago
Merged in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/8417ced60d04f515d53ab192dfcd92bae16ccd00
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Thanks a lot for fixing this! let's not uplift it to 1.1, not a blocking issue.

We will uplift only the blocking ones or performance improves,
Whiteboard: [mobile app] → [mobile app][not blocking][tef-triage][loop not in 1.1]
Tested. Also Mónica has seen it OK

Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.