Closed Bug 1092960 Opened 10 years ago Closed 10 years ago

Camera app to follow text selection pattern

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.2+)

RESOLVED FIXED
feature-b2g 2.2+

People

(Reporter: howie, Assigned: wilsonpage)

References

Details

Attachments

(3 files)

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text.
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);
No big impact on camera (unless we want to explicit make text displayed in labels/titles/menu items names etc non-selectable). Assigning to wilson to check to make sure there isn't anything missed. 

Thanks
Hema
Assignee: nobody → wilsonpage
This is a 2.2 feature.
feature-b2g: 2.2? → 2.2+
Blocks: 2.2-camera
Attached file pull-request (master)
Attachment #8524617 - Flags: review?(jdarcangelo)
Comment on attachment 8524617 [details] [review]
pull-request (master)

Is the attached patch even required? I've just blanket prevented all user-selection in the camera app.
Attachment #8524617 - Flags: feedback?(hochang)
Comment on attachment 8524617 [details] [review]
pull-request (master)

LGTM, but as you said in Comment 5, is this even required? No harm in adding it though I suppose.
Attachment #8524617 - Flags: review?(jdarcangelo) → review+
Attached image triggered use case.png
I think it's required, we need to disable text selection in the use case like the picture shown, thanks.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
QA Whiteboard: [2.2-feature-qa+]
You need to log in before you can comment on or make changes to this bug.