1092960 - Camera app to follow text selection pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[howie [:howie]]

Attachment: FxOS 2.2 Text Selection Guidelines 03.pdf

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text.

Comment 1

[howie [:howie]]

The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);

Comment 2

[Hema Koka [:hema]]

No big impact on camera (unless we want to explicit make text displayed in labels/titles/menu items names etc non-selectable). Assigning to wilson to check to make sure there isn't anything missed. 

Thanks
Hema

Comment 3

[howie [:howie]]

This is a 2.2 feature.

Comment 4

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 5

[Wilson Page [:wilsonpage]]

Comment on attachment 8524617 [details] [review]
pull-request (master)

Is the attached patch even required? I've just blanket prevented all user-selection in the camera app.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8524617 [details] [review]
pull-request (master)

LGTM, but as you said in Comment 5, is this even required? No harm in adding it though I suppose.

Comment 7

[howie [:howie]]

Attachment: triggered use case.png

I think it's required, we need to disable text selection in the use case like the picture shown, thanks.

Comment 8

[Wilson Page [:wilsonpage]]

Comment on attachment 8524617 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/6fd1aeed77c7f5f92241a5d9d4c7f2dfb554fb8c