1092966 - FM Radio app to follow text selection pattern

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[howie [:howie]]

Attachment: FxOS 2.2 Text Selection Guidelines 03.pdf

* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. 

* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.

Comment 1

[howie [:howie]]

The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);

Comment 2

[Hema Koka [:hema]]

No impact on FMRadio either based on page 12 in spec: https://bug1092944.bugzilla.mozilla.org/attachment.cgi?id=8515798. Assigning to Justin to make sure we are not missing anything (make labels/titles non-selectable if they are not already). 

Thanks
Hema

Comment 3

[howie [:howie]]

This is a 2.2 feature.

Comment 4

[howie [:howie]]

Hi Justin, may we know if you are working on this one? thank you!

Comment 5

[howie [:howie]]

ni Hema to make sure this land before Jan 12th.

Comment 6

[Justin D'Arcangelo [:justindarc]]

(In reply to howie [:howie] from comment #4)
> Hi Justin, may we know if you are working on this one? thank you!

Yes, I'm working on this. I've been on holiday, but I'm resuming work today.

Comment 7

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Comment 8

[Pin Zhang [:pzhang] (inactive)]

Comment on attachment 8545372 [details] [review]
pull-request (master)

r=me, but i don't understand one of the comments in this patch, i.e. /* 1 */, please remove it if it's useless, thanks.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/097a8526d36e5d1ba4b2eb97d16f1a472a89c4f5