Music app to follow text selection pattern

RESOLVED FIXED in 2.2 S3 (9jan)

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: hochang, Assigned: dkuo)

Tracking

unspecified
2.2 S3 (9jan)
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(feature-b2g:2.2+, b2g-v2.2 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
* Input fields (input areas, input dialogs and search fields) are the only Building Blocks with selectable text. 

* HTML elements like buttons or links, or events like ontouchstart or onclick, should trigger the action when tapped rather than triggering text selection.
(Reporter)

Comment 1

5 years ago
The Gecko work is close to completion, the remaining part is to fix test case failures then pref it on in m-c bug 1092888. After the bug landed, text selection and cut/copy/paste can be triggered in apps on both editable and non-editable elements.

Gaia per app work in v2.2 is to follow UX guideline and leverage CSS -moz-user-select https://developer.mozilla.org/en-US/docs/Web/CSS/user-select to make certain elements non-selectable.

Before Gecko is pref on in m-c, Gaia can manually switch it on by the following two pref to test in advance:
pref("selectioncaret.enabled", on);
pref("selectioncaret.noneditable", on);

Updated

5 years ago
Blocks: 2.2-music
(Reporter)

Comment 2

5 years ago
This is a 2.2 feature.
feature-b2g: 2.2? → 2.2+

Updated

5 years ago
Assignee: nobody → dflanagan
QA Contact: echang
QA Whiteboard: [2.2-feature-qa+]
This bug has been sitting in my queue for a couple of weeks. I've just reviewed similar patches for Video and Gallery, which has made me realize that this patch won't be trivial like those were because the Music app has a search feature that needs to have text selection enabled.

Dominic: is this a bug you can take? If not, please ask Jim to take it.
Assignee: dflanagan → nobody
Flags: needinfo?(dkuo)
(Assignee)

Comment 4

4 years ago
Sure, I can take this.
Assignee: nobody → dkuo
Flags: needinfo?(dkuo)
Once we know the possible effort, it would be great if you could update the target milestone. Thanks.
Flags: needinfo?(dkuo)
(Assignee)

Comment 6

4 years ago
Posted file patch
Jim, would you please review this patch? thanks.
Flags: needinfo?(dkuo)
Attachment #8540198 - Flags: review?(squibblyflabbetydoo)
(Assignee)

Comment 7

4 years ago
(In reply to Kevin Hu [:khu] from comment #5)
> Once we know the possible effort, it would be great if you could update the
> target milestone. Thanks.

After wrote the patch I realized this is a simple fix so should be okay to be landed by this week(If Jim get the review request), and I will just choose the closest milestone, thanks.
Target Milestone: --- → 2.2 S3 (9jan)
Comment on attachment 8540198 [details] [review]
patch

I'm not quite sure how to test this out, but by inspection, this looks good. rs=me.
Attachment #8540198 - Flags: review?(squibblyflabbetydoo) → review+
(Assignee)

Comment 9

4 years ago
Thanks Jim!

master: https://github.com/mozilla-b2g/gaia/commit/0db8a38f9fed18ae2abf5ef7e1b6e2a570b07e0e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.