1092970 - Geolocation status notification not sent

Status: VERIFIED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Santhosh Nadig]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141013195847

Steps to reproduce:

1. Disable Geolocation in the settings menu.
2. Open a browser and enter http://maps.google.com in the address bar.
3. A popup requesting permission to know your location appears. Click on "Share."
4. Request for current location by pressing on the "get location" icon. 


Actual results:

The current location is not shown on the map. Instead, the webpage appears to be unresponsive.



Expected results:

The application should notify the user that Geolocation is disabled and request it to be enabled.

Comment 1

[Santhosh Nadig]

Attachment: bug1092970.patch

Comment 2

[Josh Matthews [:jdm]]

A lot of this patch is already present in bug 811470 which I'll land presently.

Comment 3

[Josh Matthews [:jdm]]

I don't understand how the new constant is being used in this patch.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8515882 [details] [diff] [review]
bug1092970.patch

Review of attachment 8515882 [details] [diff] [review]:
-----------------------------------------------------------------

Let's revisit once bug 811470 lands.

Comment 5

[Francis Lee [:frlee]]

hi fabrice,

may i have your comment since 811470 has been landed to m-c.

Comment 6

[Francis Lee [:frlee]]

hi Tony,

per talk with Fabrice, may you please verify this issue with m-c? since 811470 has been landed.
thank you very much

Comment 7

[Tony Chung [:tchung]]

verifyme request to see if this is fixed against master build.   the dependent bug (bug 811470) was fixed 2 days ago, so should be in today's build.

Comment 8

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2.

Result: "Google Maps does not have permission to use your location" message is displayed.

Device: Flame 2.2 (Full Flash, 319mb)
BuildID: 20141105040206
Gaia: 7c9e7cabbde941b976e0e40a3a1d94e21aa9c5e9
Gecko: 62990ec7ad78
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 9

[Francis Lee [:frlee]]

hi Bhavana,

could you please check if this patch (from 811470) can be uplifted to 2.1?

Comment 10

[Francis Lee [:frlee]]

remove tako_blocker tag and ni. this issue will be tracked with 811470.