Closed Bug 1093026 Opened 10 years ago Closed 10 years ago

call_screen_manager.js can be loaded lazily

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [mobile app])

Attachments

(1 file)

Github pull request
204 bytes, text/html
borjasalguero
: review+
jaoo
: feedback+
Details 
      No description provided.
Assignee: nobody → crdlc
Blocks: 1088519
Status: NEW → ASSIGNED
Whiteboard: [mobile app]
Attached file Github pull request — 
10x
Attachment #8515917 - Flags: review?(josea.olivera)
Comment on attachment 8515917 [details]
Github pull request

Looking really good Cristian, however I would like to change a bit the patch. I left a comment on the PR. Once you address it request review at me again please. Thanks!
Attachment #8515917 - Flags: review?(josea.olivera) → feedback+
Comment on attachment 8515917 [details]
Github pull request

Addressed
Attachment #8515917 - Flags: review?(josea.olivera)
Comment on attachment 8515917 [details]
Github pull request

Moving to Borja because José is on PTO
Attachment #8515917 - Flags: review?(josea.olivera) → review?(borja.bugzilla)
Comment on attachment 8515917 [details]
Github pull request

My concern is about if there is any new delay when receiving a call if the app is not launched. Adding this in lazy loading (instead of being preloaded in the HTML), is adding any new delay to the incoming call? Could you take a look to this? Thanks!
Flags: needinfo?(crdlc)
Attachment #8515917 - Flags: review?(borja.bugzilla)
Basically analyzing the flow, the controller is initialized by boot.js which is the last library loaded so if we load the call_screen_manager.js before/after is the same time and this means that it shouldn't penalize receiving a call. What do you think? Thanks

(In reply to Borja Salguero [:borjasalguero] from comment #5)
> Comment on attachment 8515917 [details]
> Github pull request
> 
> My concern is about if there is any new delay when receiving a call if the
> app is not launched. Adding this in lazy loading (instead of being preloaded
> in the HTML), is adding any new delay to the incoming call? Could you take a
> look to this? Thanks!
Flags: needinfo?(crdlc) → needinfo?(borja.bugzilla)
Comment on attachment 8515917 [details]
Github pull request

Thanks for taking a look to this. Please rebase and merge this approach! Thanks!
Flags: needinfo?(borja.bugzilla)
Attachment #8515917 - Flags: review+
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/88ea273dfeb3b94e959063d1f792abafb5b6d508
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: