Closed
Bug 1093032
Opened 10 years ago
Closed 10 years ago
review/update SDK code to deal with Symbol/iteration changes
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zombie, Unassigned)
References
Details
Attachments
(1 file)
from bug 1092231 (which is just scoped to traits fixes).
the clever hack with iteratorSymbol was a good idea, but wont work because Symbols are not enumerated with Object.getOwnPropertyNames().
basically, grep for all uses of "Symbol.iterator", "iteratorSymbol" and "getOwnPropertyNames" and review if changes are required/desired.
|
Reporter | |
Updated•10 years ago
|
Summary: review/update SDK code to deal with `Symbol`s → review/update SDK code to deal with Symbol/iteration changes
|
||
Comment 1•10 years ago
|
||
Attachment #8517222 -
Flags: review?(dtownsend+bugmail)
|
||
Comment 2•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/647746d28469a4adcf489e34737095784fd85de5
Merge pull request #1697 from Gozala/bug/symbol-iterator@1093032
Bug 1093032 - Fix regressions caused by Symbol.iterator r=@Mossop
|
||
Updated•10 years ago
|
Attachment #8517222 -
Flags: review?(dtownsend+bugmail) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(rFobic)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•