Closed
Bug 1093048
Opened 10 years ago
Closed 10 years ago
add string overload for nsIDOMWindowUtils::removeSheet method (e10s)
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
| Tracking | Status | |
|---|---|---|
| e10s | + | --- |
People
(Reporter: zombie, Assigned: mossop)
References
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1089230 +++
i forgot to ask for removeSheet() method in bug 1089230.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Attachment #8516229 -
Flags: review?(bobbyholley)
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Updated•10 years ago
|
Flags: qe-verify-
Flags: firefox-backlog+
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8516229 [details] [diff] [review]
patch
Review of attachment 8516229 [details] [diff] [review]:
-----------------------------------------------------------------
Hrm. 'RemoveSheetFromURIString' has an unfortunate semantic connotation that the sheet is being removed from the string (whereas 'LoadSheetFromURIString' has no such ambiguity).
Can we change both of them to LoadSheetUsingURIString and RemoveSheetUsingURIString? r=me with that.
Attachment #8516229 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•