add string overload for nsIDOMWindowUtils::removeSheet method (e10s)

RESOLVED FIXED in mozilla36

Status

()

defect
RESOLVED FIXED
5 years ago
5 months ago

People

(Reporter: zombie, Assigned: mossop)

Tracking

unspecified
mozilla36
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(e10s+)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #1089230 +++

i forgot to ask for removeSheet() method in bug 1089230.
Posted patch patchSplinter Review
Assignee: nobody → dtownsend+bugmail
Status: NEW → ASSIGNED
Attachment #8516229 - Flags: review?(bobbyholley)
tracking-e10s: --- → +
Component: General → DOM
Product: Add-on SDK → Core
Flags: qe-verify-
Flags: firefox-backlog+
Comment on attachment 8516229 [details] [diff] [review]
patch

Review of attachment 8516229 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm. 'RemoveSheetFromURIString' has an unfortunate semantic connotation that the sheet is being removed from the string (whereas 'LoadSheetFromURIString' has no such ambiguity).

Can we change both of them to LoadSheetUsingURIString and RemoveSheetUsingURIString? r=me with that.
Attachment #8516229 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/fb567390cb92
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.