1093066 - Get rid of gfxContext's Stroke() methods

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8515966 [details] [diff] [review]
patch

Review of attachment 8515966 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/svg/SVGContentUtils.cpp
@@ +162,5 @@
>                                    gfxTextContextPaint *aContextPaint,
>                                    StrokeOptionFlags aFlags)
>  {
> +  nsSVGElement* element =
> +    static_cast<nsSVGElement*>(aContent->IsNodeOfType(nsINode::eTEXT) ?

This makes me a little queasy. Can we do this in the caller, or at least document and assert?

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8515966 [details] [diff] [review]
patch

Review of attachment 8515966 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/svg/SVGContentUtils.cpp
@@ +162,5 @@
>                                    gfxTextContextPaint *aContextPaint,
>                                    StrokeOptionFlags aFlags)
>  {
> +  nsSVGElement* element =
> +    static_cast<nsSVGElement*>(aContent->IsNodeOfType(nsINode::eTEXT) ?

Yeah, agreed. We should be able to do this in the SVGTextFrame caller and not have it here right?

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

So boring.

Being more serious, this was just what the old code was doing, but yeah, we can be safer.

Comment 5

[Jonathan Watt [:jwatt]]

Comment on attachment 8516214 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/d960256cdb80

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d960256cdb80