1093098 - crash in java.lang.UnsupportedOperationException: JNI Function called before it was loaded at org.mozilla.gecko.ANRReporter.requestNativeStack(Native Method)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-0adc85fb-4d8c-4c33-acac-bb3112141102.
=============================================================

java.lang.UnsupportedOperationException: JNI Function called before it was loaded
	at org.mozilla.gecko.ANRReporter.requestNativeStack(Native Method)
	at org.mozilla.gecko.ANRReporter.onReceive(ANRReporter.java:586)
	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:755)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.ANRReporter$1.run(ANRReporter.java:96)
	at java.lang.Thread.run(Thread.java:856)

Comment 1

[Richard Newman [:rnewman]]

Only two crashes, so I guess nchen can look at this when he's back.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't get native stack before libs are loaded (v1)

Quietly skip getting the native stack if libs are not loaded.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8518393 [details] [diff] [review]
Don't get native stack before libs are loaded (v1)

Review of attachment 8518393 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/ANRReporter.java
@@ +474,5 @@
> +        boolean haveNativeStack = false;
> +        try {
> +            // Unwinding is memory intensive; only unwind if we have enough memory.
> +            haveNativeStack = requestNativeStack(/* unwind */ SysInfo.getMemSize() >= 640);
> +        } catch (final UnsupportedOperationException e) {

Maybe you could just use GeckoThread.checkLaunchState() to make sure we're running? Not really sure what the advantage would be. Maybe requestNativeStack() could crash if we are in some sorta-running-but-not-really state?

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't get native stack before libs are loaded (v1.1)

Changed to using GeckoThread.checkLaunchState().

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

https://tbpl.mozilla.org/?tree=Try&rev=a574f10a0327

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/48e460577514

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48e460577514