1093119 - about:feedback page is aligned to left

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristina Madaras, QA [:CristinaM]]

Attachment: about_feedback.png

Environment
Build: Firefox for Android 36.0a1 (2014-11-03)
Device: Asus Transformer TF101 (Android 4.0.3)

Steps to reproduce:
1. Launch Fennec and navigate to about:feedback.

Expected results:
Page is aligned to center.

Actual results:
Page is aligned to left.

Regression window:
Last good: 2014-10-06
First bad: 2014-10-07

Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0ed32d9a42d6&tochange=9ee9e193fc48

Notes: Please see the attachment.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: Bug 1007436 looks like the regressor.

Comment 2

[Vivek Balakrishnan[:vivek]]

Attachment: 1093119.patch

This patch centers all the sections in the html document.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8516978 [details] [diff] [review]
1093119.patch

Review of attachment 8516978 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, and it looks good on my N4, but I wonder whether or not we still need this 20px margin. r+, but I'll review another version of the patch if you agree with my suggestion below.

::: mobile/android/themes/core/aboutFeedback.css
@@ +20,4 @@
>    overflow: auto;
>    height: calc(100% - 80px);
> +  margin: 20px auto;
> +  padding: 25px;

If we're updating this padding value, do we still need the top/bottom 20px margin? Or could we just restore the margin-left/margin-right: auto;, then replace the margin/padding declaration with this new padding declaration?

Comment 4

[Vivek Balakrishnan[:vivek]]

Attachment: 1093119.patch

@Margaret: yes, I've restored margin-left/right and added the margin value to padding as you suggested.

Comment 5

[:Margaret Leibovic]

Comment on attachment 8517596 [details] [diff] [review]
1093119.patch

Review of attachment 8517596 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

Comment 6

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/7ef22f247d76

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ef22f247d76

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Build: Firefox for Android 36.a01 (2014-11-09)
Device: Asus Transformer Pad TF300T (Android 4.2.1)

Comment 9

[:Margaret Leibovic]

Comment on attachment 8517596 [details] [diff] [review]
1093119.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1007436
[User impact if declined]: about:feedback is misaligned on tablets
[Describe test coverage new/current, TBPL]: no test coverage, tested locally and baked om m-c
[Risks and why]: low-risk, small style change 
[String/UUID change made/needed]: none

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d6cb8e03dc06

Comment 11

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Build: Firefox for Android 35.0a2 (2014-11-16)
Device: Asus Transformer Pad TF300T (Android 4.2.1)