Closed Bug 1093131 Opened 5 years ago Closed 5 years ago

Add a test that delete browser's history

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bebe, Assigned: Bebe)

References

Details

Attachments

(1 file)

Add a test to check that a user can clear the browser history
Peter do we have a manual test case for this test?
Flags: needinfo?(pbylenga)
QA Whiteboard: fxosqa-auto-from-s2
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]
We don't test this in smoketest runs but it is covered in functional runs.

https://moztrap.mozilla.org/manage/cases/?filter-id=3582
Flags: needinfo?(pbylenga)
Attachment #8516795 - Flags: review?(zcampbell)
Attachment #8516795 - Flags: review?(viorela.ioia)
Attachment #8516795 - Flags: review?(robert.chira)
Comment on attachment 8516795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25816

Comments in the PR.
Attachment #8516795 - Flags: review?(robert.chira) → review-
Comment on attachment 8516795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25816

Comments in the PR
Attachment #8516795 - Flags: review?(viorela.ioia) → review-
Comment on attachment 8516795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25816

I still don't like the name of the class "NewTab". It's more like a list/page region than a new tab.
Attachment #8516795 - Flags: review?(zcampbell) → review-
Attachment #8516795 - Flags: review?(zcampbell)
Attachment #8516795 - Flags: review?(viorela.ioia)
Attachment #8516795 - Flags: review-
Comment on attachment 8516795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25816

r-, use proper PageRegion
Attachment #8516795 - Flags: review?(zcampbell) → review-
Comment on attachment 8516795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25816

Comments updated. Can you take a new look over the pull

Also I'm open to rename this to a more clear class name. Any suggestions?
Attachment #8516795 - Flags: review- → review?(zcampbell)
Depends on: 1095498
QA Whiteboard: [fxosqa-auto-from-s2] [fxosqa-auto-s3] → [fxosqa-auto-from-s2] [fxosqa-auto-s3][fxosqa-auto-from-s2] [fxosqa-auto-s4]
QA Whiteboard: [fxosqa-auto-from-s2] [fxosqa-auto-s3][fxosqa-auto-from-s2] [fxosqa-auto-s4] → [fxosqa-auto-from-s2] [fxosqa-auto-s3][fxosqa-auto-from-s3] [fxosqa-auto-s4]
QA Whiteboard: [fxosqa-auto-from-s2] [fxosqa-auto-s3][fxosqa-auto-from-s3] [fxosqa-auto-s4] → [fxosqa-auto-from-s2] [fxosqa-auto-s3] [fxosqa-auto-from-s3] [fxosqa-auto-s4]
QA Whiteboard: [fxosqa-auto-from-s2] [fxosqa-auto-s3] [fxosqa-auto-from-s3] [fxosqa-auto-s4] → [fxosqa-auto-from-s2] [fxosqa-auto-from-s3] [fxosqa-auto-s4]
Comment on attachment 8516795 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25816

r+
Attachment #8516795 - Flags: review?(zcampbell) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.