1093165 - incorporate the text-orientation value into mozilla::WritingMode

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Kew [:jfkthame]]

When constructing a WritingMode, we need to take account of the text-orientation property as well as writing-mode. This is needed to allow us to determine the correct dominant baseline[1], and to map line-relative directions to physical directions properly[2].

This will help with upcoming patches to fix various baseline and vertical alignment issues.

[1] http://www.w3.org/TR/css3-writing-modes/#text-baselines
[2] http://www.w3.org/TR/css3-writing-modes/#line-directions

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Include the text-orientation value in WritingMode, and add the IsSideways flag for baseline decisions.

Comment 2

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfd8c44bfe86

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bfd8c44bfe86