1093174 - logalloc doesn't properly record allocation sizes for calloc calls

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Guilherme Gonçalves [:ggp]]

For a call like |calloc(x, y)|, the corresponding MemSlot's mSize field should be set to x * y. It is currently being set to just y.

Comment 1

[Guilherme Gonçalves [:ggp]]

Attachment: Properly compute the total size for calloc() calls.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8516052 [details] [diff] [review]
Properly compute the total size for calloc() calls.

Review of attachment 8516052 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/replace/logalloc/replay/Replay.cpp
@@ +393,5 @@
>      mOps++;
>      size_t num = parseNumber(aArgs.SplitChar(','));
>      size_t size = parseNumber(aArgs);
>      aSlot.mPtr = ::calloc_impl(num, size);
> +    aSlot.mSize = size * num;

duh

Comment 3

[Guilherme Gonçalves [:ggp]]

Thanks!

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=df9ed3e966ca

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e9000715f0c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e9000715f0c