Closed Bug 1093220 Opened 9 years ago Closed 9 years ago

Remove logic for loading search engine in search activity from assets

Categories

(Firefox for Android Graveyard :: Search Activity, defect)

Product:
Firefox for Android Graveyard
Component:
Search Activity
Version:
35 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox35 fixed, firefox36 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: Margaret, Assigned: shashank, Mentored)

References

Details

(Whiteboard: [lang=java][good first bug])

Attachments

(1 file)

BUG1093220.patch
3.50 KB, patch
Margaret
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
This code was required when we supported a standalone search activity, but now that we require shipping it with Fennec, we can get rid of this.

We should remove the getEngineFromAssets method and places where it's called:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java#219
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java#188

Same thing for reading the engine list:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java#136
Attached patch BUG1093220.patch — — Splinter Review 
Removed definition and 1 call of 'getEngineFromAssets()' and a 'context.getResources().getAssets().open()'
Assignee: nobody → shashank
Status: NEW → ASSIGNED
Attachment #8519595 - Flags: review?(margaret.leibovic)
Comment on attachment 8519595 [details] [diff] [review]
BUG1093220.patch

Review of attachment 8519595 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!
Attachment #8519595 - Flags: review?(margaret.leibovic) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/2da1175e49c8
Keywords: checkin-needed
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2da1175e49c8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 36
We should uplift this patch to make uplifting bug 1091728 easier.
Blocks: 1091728
Comment on attachment 8519595 [details] [diff] [review]
BUG1093220.patch

Approval Request Comment
[Feature/regressing bug #]: search activity
[User impact if declined]: it will be harder to uplift bug 1091728
[Describe test coverage new/current, TBPL]: no tests, baked on m-c
[Risks and why]: low-risk, removes some unused code paths
[String/UUID change made/needed]: none
Attachment #8519595 - Flags: approval-mozilla-aurora?
Attachment #8519595 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.