1093220 - Remove logic for loading search engine in search activity from assets

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[:Margaret Leibovic]

This code was required when we supported a standalone search activity, but now that we require shipping it with Fennec, we can get rid of this.

We should remove the getEngineFromAssets method and places where it's called:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java#219
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java#188

Same thing for reading the engine list:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/search/java/org/mozilla/search/providers/SearchEngineManager.java#136

Comment 1

[Shashank VRSN Sabniveesu]

Attachment: BUG1093220.patch

Removed definition and 1 call of 'getEngineFromAssets()' and a 'context.getResources().getAssets().open()'

Comment 2

[:Margaret Leibovic]

Comment on attachment 8519595 [details] [diff] [review]
BUG1093220.patch

Review of attachment 8519595 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thanks!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2da1175e49c8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2da1175e49c8

Comment 5

[:Margaret Leibovic]

We should uplift this patch to make uplifting bug 1091728 easier.

Comment 6

[:Margaret Leibovic]

Comment on attachment 8519595 [details] [diff] [review]
BUG1093220.patch

Approval Request Comment
[Feature/regressing bug #]: search activity
[User impact if declined]: it will be harder to uplift bug 1091728
[Describe test coverage new/current, TBPL]: no tests, baked on m-c
[Risks and why]: low-risk, removes some unused code paths
[String/UUID change made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/134e4af41d65