Closed
Bug 1093221
Opened 11 years ago
Closed 11 years ago
[e10s] RemoteWebNavigation.loadURI should accept and pass referrer arguments.
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
| Tracking | Status | |
|---|---|---|
| e10s | + | --- |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
|
9.73 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
It should also have some direct testing.
Flags: qe-verify-
Flags: firefox-backlog+
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8516275 -
Flags: review?(mconley)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8516275 [details] [diff] [review]
patch
Review of attachment 8516275 [details] [diff] [review]:
-----------------------------------------------------------------
I do like seeing more tests. Thanks for those. :)
I'm not 100% certain we need the dummy_page.html document. If a data URI suffices, it might be simpler just to use that. If, however, the dummy_page document is required, proceed.
::: toolkit/modules/tests/browser/browser.ini
@@ +1,2 @@
> [DEFAULT]
> +support-files =
Nit - trailing ws
::: toolkit/modules/tests/browser/browser_RemoteWebNavigation.js
@@ +1,5 @@
> +const { interfaces: Ci, classes: Cc, utils: Cu, results: Cr } = Components;
> +
> +const DUMMY = "browser/toolkit/modules/tests/browser/dummy_page.html";
> +
> +function waitForLoad(browser = gBrowser.selectedBrowser) {
Guh, here we go again. :/ Bug 1093566 will be nice to get fixed.
@@ +25,5 @@
> + getService(Ci.nsIIOService).
> + newURI(url, null, null);
> +}
> +
> +add_task(function* test_referrer() {
A quick docstring above each test quickly explaining what they're testing would be great.
@@ +95,5 @@
> + null, null, null);
> + yield waitForLoad();
> +
> + let history = browser.webNavigation.sessionHistory;
> + is(history.count, 1, "Should be two history items");
"Should be one history item".
@@ +105,5 @@
> + Ci.nsIWebNavigation.LOAD_FLAGS_BYPASS_HISTORY,
> + null, null, null);
> + yield waitForLoad();
> +
> + is(history.count, 1, "Should be two history items");
"Should still be one history item"
::: toolkit/modules/tests/browser/dummy_page.html
@@ +1,1 @@
> +<!DOCTYPE html>
Can I assume this is required, and a data URI will not suffice?
Attachment #8516275 -
Flags: review?(mconley) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Referrer is a feature of HTTP so we need the dummy page.
https://hg.mozilla.org/integration/fx-team/rev/e40650d15c28
|
||
Updated•11 years ago
|
tracking-e10s:
--- → +
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Depends on: 1153457
You need to log in
before you can comment on or make changes to this bug.
Description
•