1093372 - Multiple calls to LightweightThemeManager.previewTheme() in a row cause a leak in Windows debug builds

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: previewThemes.patch

As I discovered when trying to call previewTheme twice in a row in a test, doing this causes a leak on Windows debug builds.  Here is a sample try push with the attached patch: https://tbpl.mozilla.org/?tree=Try&rev=7e5cad4b15e6.

The patch leaks with a test that does this:

   let {LightweightThemeManager} = Components.utils.import("resource://gre/modules/LightweightThemeManager.jsm", {});
   LightweightThemeManager.previewTheme(dummyLightweightTheme("preview0"));
   LightweightThemeManager.previewTheme(dummyLightweightTheme("preview1"));
   LightweightThemeManager.resetPreview();
   LightweightThemeManager.previewTheme(dummyLightweightTheme("preview2"));
   LightweightThemeManager.resetPreview();
   ok(true, "done");
   finish();

It doesn't leak if it's like this:

   let {LightweightThemeManager} = Components.utils.import("resource://gre/modules/LightweightThemeManager.jsm", {});
   LightweightThemeManager.previewTheme(dummyLightweightTheme("preview0"));
   LightweightThemeManager.resetPreview();
   LightweightThemeManager.previewTheme(dummyLightweightTheme("preview1"));
   LightweightThemeManager.resetPreview();
   LightweightThemeManager.previewTheme(dummyLightweightTheme("preview2"));
   LightweightThemeManager.resetPreview();
   ok(true, "done");
   finish();

Comment 1

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.