Closed Bug 1093373 Opened 6 years ago Closed 5 years ago

e10s -- Fix browser/base/content/test/general/ browser chrome tests relying on browser.sessionHistory

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.3 - 11 May
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: Gijs, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

All of the following hang or break with something like:

629 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug816527.js | uncaught exception - TypeError: testTab.linkedBrowser.sessionHistory is null at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug816527.js:63
Stack trace:
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1346
null:null:0
630 INFO Console message: [JavaScript Error: "TypeError: testTab.linkedBrowser.sessionHistory is null" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug816527.js" line: 63}]


[browser_bug555767.js]
[browser_bug647886.js]
[browser_bug816527.js]
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
Comment on attachment 8597984 [details] [diff] [review]
Fix for browser_bug647886

Test run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad8793ebfea1
Attachment #8597984 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8597984 [details] [diff] [review]
Fix for browser_bug647886

Review of attachment 8597984 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_bug647886.js
@@ +17,4 @@
>    EventUtils.synthesizeMouseAtCenter(backButton, {type: "mousedown"});
>    EventUtils.synthesizeMouse(backButton, rect.width / 2, rect.height, {type: "mouseup"});
> +  let event = yield popupShownPromise;
> +  

Nit: trailing ws
Attachment #8597984 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Iteration: --- → 40.3 - 11 May
Points: --- → 3
https://hg.mozilla.org/mozilla-central/rev/ba0460bfab05
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
The fix that landed a few months ago only addressed one of the three test cases reported as affected. I'll file a separate bug for browser_bug555767.js, as I have been trying to fix it. It appears that browser_bug816527.js no longer exists.
You need to log in before you can comment on or make changes to this bug.