1093373 - e10s -- Fix browser/base/content/test/general/ browser chrome tests relying on browser.sessionHistory

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (he/him)]

All of the following hang or break with something like:

629 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug816527.js | uncaught exception - TypeError: testTab.linkedBrowser.sessionHistory is null at chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug816527.js:63
Stack trace:
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1346
null:null:0
630 INFO Console message: [JavaScript Error: "TypeError: testTab.linkedBrowser.sessionHistory is null" {file: "chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug816527.js" line: 63}]


[browser_bug555767.js]
[browser_bug647886.js]
[browser_bug816527.js]

Comment 1

[Neil Deakin]

Attachment: Fix for browser_bug647886

Comment 2

[Neil Deakin]

Comment on attachment 8597984 [details] [diff] [review]
Fix for browser_bug647886

Test run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad8793ebfea1

Comment 3

[:Gijs (he/him)]

Comment on attachment 8597984 [details] [diff] [review]
Fix for browser_bug647886

Review of attachment 8597984 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_bug647886.js
@@ +17,4 @@
>    EventUtils.synthesizeMouseAtCenter(backButton, {type: "mousedown"});
>    EventUtils.synthesizeMouse(backButton, rect.width / 2, rect.height, {type: "mouseup"});
> +  let event = yield popupShownPromise;
> +  

Nit: trailing ws

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0460bfab05

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba0460bfab05

Comment 6

[Tracy Walker [:tracy]]

The fix that landed a few months ago only addressed one of the three test cases reported as affected. I'll file a separate bug for browser_bug555767.js, as I have been trying to fix it. It appears that browser_bug816527.js no longer exists.