Devedition Theme: New tab and all tab buttons have the default toolbar background color on OSX when tabs aren't in titlebar and with overflowing tabs

VERIFIED FIXED in Firefox 35

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

Trunk
Firefox 36
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox35 fixed, firefox36 verified)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Another case where I'm not sure if it would be best to just use !important or to just copy the selector list from browser.css.  I went ahead and copied the list but let me know if you think there's a better way to do this.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8516403 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8516403 [details] [diff] [review]
tabstoolbar-overflowing-tabs.patch

You can use !important here. The selector should be as simple as '#TabsToolbar', as I understand it. Or am I missing some case where -moz-appearance:none isn't wanted?
Attachment #8516403 - Flags: review?(gijskruitbosch+bugs) → review-
(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 8516403 [details] [diff] [review]
> tabstoolbar-overflowing-tabs.patch
> 
> You can use !important here. The selector should be as simple as
> '#TabsToolbar', as I understand it. Or am I missing some case where
> -moz-appearance:none isn't wanted?

Good point - I can't really think of a time we don't want -moz-appearance none here so I'll update the patch to use !important.
This fixes the issue for me
Attachment #8516403 - Attachment is obsolete: true
Attachment #8516772 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8516772 [details] [diff] [review]
tabstoolbar-overflowing-tabs.patch

stealing again
Attachment #8516772 - Flags: review?(gijskruitbosch+bugs) → review+
Attachment #8516772 - Attachment is obsolete: true
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/de9c2a2f67eb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
This looks fixed in latest gum build (https://hg.mozilla.org/projects/gum/rev/f426e446b9aa) using Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Group: mozilla-employee-confidential
You need to log in before you can comment on or make changes to this bug.