1093616 - Default permissions for contrib/replyrc are wrong

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Gervase Markham [:gerv]]

gerv@hare:/usr/src/bugzilla$ git diff
gerv@hare:/usr/src/bugzilla$ ./checksetup.pl 
* This is Bugzilla 5.1 on perl 5.18.2
...
Fixing file permissions...
checksetup.pl complete.

gerv@hare:/usr/src/bugzilla$ git diff
diff --git a/contrib/replyrc b/contrib/replyrc
old mode 100644
new mode 100755
gerv@hare:/usr/src/bugzilla$ 

Looks like the default permissions are not those that checksetup sets the permissions to.

Gerv

Comment 1

[Dylan Hardison [:dylan] (he/him)]

checksetup should probably ignore that file (or files that are not scripts).

Comment 2

[Frédéric Buclin]

(In reply to Dylan William Hardison [:dylan] from comment #1)
> checksetup should probably ignore that file (or files that are not scripts).

No, permissions should be set correctly. You forgot to update Bugzilla::Install::Filesystem.pm accordingly.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Please revert http://git.mozilla.org/?p=bugzilla/bugzilla.git;a=commit;h=da539e8c20bc4facc36002a482d07869872f1011 [github]

This change is wrong.

Comment 4

[Gervase Markham [:gerv]]

Reverted:
To ssh://[e-mail]/bugzilla/bugzilla.git
   da539e8..dd9352e  master -> master

Gerv

Comment 5

[Gervase Markham [:gerv]]

The current committed permissions:
-rw-rw-r-- 1 gerv gerv 904 Nov 29 12:47 contrib/replyrc
After checksetup:
-rwx------ 1 gerv www-data 904 Nov 29 12:47 contrib/replyrc
because of this:
         'contrib'             => { files => OWNER_EXECUTE,
                                     dirs => DIR_OWNER_WRITE, },

I think what we actually want is:
-rw------- 1 gerv www-data 904 Nov 29 12:47 contrib/replyrc

which can be achieved by adding:
        'contrib/replyrc'      => { perms => OWNER_WRITE },
at line 170.

Is that right?

Gerv

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 8530500 [details] [diff] [review]
patch, v1

Review of attachment 8530500 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, duh. How did I not see this? Sorry.

Gerv

Comment 7

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   dd9352e..c0dbbc6  master -> master