1093619 - Don't display onboarding screen for Webapp profiles

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Flaviu Cos]

Environment: 
Device: Nexus 4 (Android 4.4.4);
Build: Nightly 36.0a1 (2014-11-04);

Steps to reproduce:
1. Launch fennec;
2. Go to marketplace.firefox.com
3. Install any app;
4. Tap on the 'Open' button after the installation wizard is complete;
5. While the installed app is loading tap the android home button;
6. Kill the opening app and fennec from the recent apps page;
7. Launch fennec.

Expected result:
Fennec is correctly launched

Actual result:
The onboarding screen is displayed.

Notes:
Please check the video: http://youtu.be/aIL7o59KaJI

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: the first run screen should only show once

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Is Fennec somehow using the WebApp's profile? The only way the Onboarding popup should appear is if the profile is new.

Comment 3

[Chenxia Liu [:liuche]]

Hmm, I think it must be using the WebApp profile, because the pref to show the dialog should be getting set to false. We should add a check that we aren't in a WebApp profile when deciding whether to display onboarding.

I can repro this by opening the new webapp and simply hitting back - no need to close and restart.

Comment 4

[Chenxia Liu [:liuche]]

Attachment: Patch: Don't display onboarding screen for Webapp profiles.

Check that profile is not a webapp profile before setting first run startpane pref.

Comment 5

[:Margaret Leibovic]

Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Review of attachment 8520077 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoProfile.java
@@ +693,5 @@
>              Log.w(LOGTAG, "Couldn't write times.json.", e);
>          }
>  
> +        // Initialize pref flag for displaying the start pane for a new non-webapp profile.
> +        if (!mIsWebAppProfile) {

Do we also need to check guest profiles? Are we showing this in guest mode?

Comment 6

[Chenxia Liu [:liuche]]

Nope! We force creation of a "Guest" profile so we don't create a normal one.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoProfile.java#208

Comment 7

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/7c2e7d3f51af

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Approval Request Comment
[Feature/regressing bug #]: Onboarding didn't handle webapp profiles
[User impact if declined]: Users will see the onboarding pane every time they install a new webapp
[Describe test coverage new/current, TBPL]: Local testing, green Beta try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b3f5bca11056
[Risks and why]: very low, add an if check for webapp profiles
[String/UUID change made/needed]: none

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7c2e7d3f51af

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Beta+
Aurora+

Comment 11

[Chenxia Liu [:liuche]]

Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/e1b559002e00
Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/5cbc59a67d8c

Comment 12

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Builds:
Firefox for Android 36.0a1 (2014-11-13)
Firefox for Android 35.0a2 (2014-11-13)

Device: Nexus 4 (Android 4.4.4)

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Based on Flaviu's steps, the onboarding screen is not displayed, so:
Verified as fixed on:
Device: LG Nexus 4 (Android 4.4)
Build: Firefox for Android 34 Beta 10