Closed Bug 1093619 Opened 7 years ago Closed 7 years ago

Don't display onboarding screen for Webapp profiles


(Firefox for Android Graveyard :: General, defect)

Not set


(firefox34+ verified, firefox35+ verified, firefox36+ verified, fennec34+)

Firefox 36
Tracking Status
firefox34 + verified
firefox35 + verified
firefox36 + verified
fennec 34+ ---


(Reporter: cos_flaviu, Assigned: liuche)




(1 file)

Device: Nexus 4 (Android 4.4.4);
Build: Nightly 36.0a1 (2014-11-04);

Steps to reproduce:
1. Launch fennec;
2. Go to
3. Install any app;
4. Tap on the 'Open' button after the installation wizard is complete;
5. While the installed app is loading tap the android home button;
6. Kill the opening app and fennec from the recent apps page;
7. Launch fennec.

Expected result:
Fennec is correctly launched

Actual result:
The onboarding screen is displayed.

Please check the video:
[Tracking Requested - why for this release]: the first run screen should only show once
tracking-fennec: --- → ?
Blocks: firstrun
Is Fennec somehow using the WebApp's profile? The only way the Onboarding popup should appear is if the profile is new.
Flags: needinfo?(liuche)
Hmm, I think it must be using the WebApp profile, because the pref to show the dialog should be getting set to false. We should add a check that we aren't in a WebApp profile when deciding whether to display onboarding.

I can repro this by opening the new webapp and simply hitting back - no need to close and restart.
Flags: needinfo?(liuche)
Assignee: nobody → liuche
tracking-fennec: ? → 34+
Summary: Onboarding screen is displayed even if fennec is not at it's first launch → Don't display onboarding screen for Webapp profiles
Check that profile is not a webapp profile before setting first run startpane pref.
Attachment #8520077 - Flags: review?(margaret.leibovic)
Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Review of attachment 8520077 [details] [diff] [review]:

::: mobile/android/base/
@@ +693,5 @@
>              Log.w(LOGTAG, "Couldn't write times.json.", e);
>          }
> +        // Initialize pref flag for displaying the start pane for a new non-webapp profile.
> +        if (!mIsWebAppProfile) {

Do we also need to check guest profiles? Are we showing this in guest mode?
Attachment #8520077 - Flags: review?(margaret.leibovic) → review+
Nope! We force creation of a "Guest" profile so we don't create a normal one.
Target Milestone: --- → Firefox 36
Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Approval Request Comment
[Feature/regressing bug #]: Onboarding didn't handle webapp profiles
[User impact if declined]: Users will see the onboarding pane every time they install a new webapp
[Describe test coverage new/current, TBPL]: Local testing, green Beta try run:
[Risks and why]: very low, add an if check for webapp profiles
[String/UUID change made/needed]: none
Attachment #8520077 - Flags: approval-mozilla-beta?
Attachment #8520077 - Flags: approval-mozilla-aurora?
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Attachment #8520077 - Flags: approval-mozilla-beta?
Attachment #8520077 - Flags: approval-mozilla-beta+
Attachment #8520077 - Flags: approval-mozilla-aurora?
Attachment #8520077 - Flags: approval-mozilla-aurora+
Verified as fixed in
Firefox for Android 36.0a1 (2014-11-13)
Firefox for Android 35.0a2 (2014-11-13)

Device: Nexus 4 (Android 4.4.4)
Based on Flaviu's steps, the onboarding screen is not displayed, so:
Verified as fixed on:
Device: LG Nexus 4 (Android 4.4)
Build: Firefox for Android 34 Beta 10
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.