Don't display onboarding screen for Webapp profiles

VERIFIED FIXED in Firefox 34

Status

()

defect
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: cos_flaviu, Assigned: liuche)

Tracking

Trunk
Firefox 36
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34+ verified, firefox35+ verified, firefox36+ verified, fennec34+)

Details

Attachments

(1 attachment)

Environment: 
Device: Nexus 4 (Android 4.4.4);
Build: Nightly 36.0a1 (2014-11-04);

Steps to reproduce:
1. Launch fennec;
2. Go to marketplace.firefox.com
3. Install any app;
4. Tap on the 'Open' button after the installation wizard is complete;
5. While the installed app is loading tap the android home button;
6. Kill the opening app and fennec from the recent apps page;
7. Launch fennec.

Expected result:
Fennec is correctly launched

Actual result:
The onboarding screen is displayed.

Notes:
Please check the video: http://youtu.be/aIL7o59KaJI
[Tracking Requested - why for this release]: the first run screen should only show once
tracking-fennec: --- → ?
Blocks: firstrun
Is Fennec somehow using the WebApp's profile? The only way the Onboarding popup should appear is if the profile is new.
Flags: needinfo?(liuche)
Hmm, I think it must be using the WebApp profile, because the pref to show the dialog should be getting set to false. We should add a check that we aren't in a WebApp profile when deciding whether to display onboarding.

I can repro this by opening the new webapp and simply hitting back - no need to close and restart.
Flags: needinfo?(liuche)
Assignee: nobody → liuche
tracking-fennec: ? → 34+
Summary: Onboarding screen is displayed even if fennec is not at it's first launch → Don't display onboarding screen for Webapp profiles
Check that profile is not a webapp profile before setting first run startpane pref.
Attachment #8520077 - Flags: review?(margaret.leibovic)
Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Review of attachment 8520077 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoProfile.java
@@ +693,5 @@
>              Log.w(LOGTAG, "Couldn't write times.json.", e);
>          }
>  
> +        // Initialize pref flag for displaying the start pane for a new non-webapp profile.
> +        if (!mIsWebAppProfile) {

Do we also need to check guest profiles? Are we showing this in guest mode?
Attachment #8520077 - Flags: review?(margaret.leibovic) → review+
Nope! We force creation of a "Guest" profile so we don't create a normal one.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoProfile.java#208
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/7c2e7d3f51af
Target Milestone: --- → Firefox 36
Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Approval Request Comment
[Feature/regressing bug #]: Onboarding didn't handle webapp profiles
[User impact if declined]: Users will see the onboarding pane every time they install a new webapp
[Describe test coverage new/current, TBPL]: Local testing, green Beta try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b3f5bca11056
[Risks and why]: very low, add an if check for webapp profiles
[String/UUID change made/needed]: none
Attachment #8520077 - Flags: approval-mozilla-beta?
Attachment #8520077 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7c2e7d3f51af
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8520077 [details] [diff] [review]
Patch: Don't display onboarding screen for Webapp profiles.

Beta+
Aurora+
Attachment #8520077 - Flags: approval-mozilla-beta?
Attachment #8520077 - Flags: approval-mozilla-beta+
Attachment #8520077 - Flags: approval-mozilla-aurora?
Attachment #8520077 - Flags: approval-mozilla-aurora+
Status: RESOLVED → VERIFIED
Verified as fixed in
Builds:
Firefox for Android 36.0a1 (2014-11-13)
Firefox for Android 35.0a2 (2014-11-13)

Device: Nexus 4 (Android 4.4.4)
Based on Flaviu's steps, the onboarding screen is not displayed, so:
Verified as fixed on:
Device: LG Nexus 4 (Android 4.4)
Build: Firefox for Android 34 Beta 10
You need to log in before you can comment on or make changes to this bug.