Closed Bug 1093654 Opened 10 years ago Closed 10 years ago

Intermittent LeakSanitizer | leak at mozilla::MediaDecoderStateMachine::FinishDecodeMetadata, mozilla::MediaDecoderStateMachine::MaybeFinishDecodeMetadata, mozilla::MediaDecoderStateMachine::OnAudioDecoded

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla36
Tracking Flags:
Tracking Status
firefox34 --- unaffected
firefox35 --- unaffected
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: cbook, Assigned: jya)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: intermittent-failure, memory-leak, Whiteboard: must be applied after 1065827)

Attachments

(1 file, 1 obsolete file)

Fix various memory leaks in MediaDecoders
27.74 KB, patch
Details | Diff | Splinter Review 
Ubuntu ASAN VM 12.04 x64 fx-team opt test mochitest-2

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=1084064&repo=fx-team

07:08:14 INFO - SUMMARY: AddressSanitizer: 352 byte(s) leaked in 2 allocation(s).
07:08:15 INFO - TEST-INFO | Main app process: exit 0
07:08:15 WARNING - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::MediaDecoderStateMachine::FinishDecodeMetadata, mozilla::MediaDecoderStateMachine::MaybeFinishDecodeMetadata, mozilla::MediaDecoderStateMachine::OnAudioDecoded
07:08:15 INFO - runtests.py | Application ran for: 0:37:43.036998
07:08:15 INFO - zombiecheck | Reading PID log: /tmp/tmp3fgBHSpidlog
07
bholley has landed a couple of patches to MediaDecoderStateMachine, maybe that is related to this leak.

This code has changed in the last few days, so I'm not exactly sure what was leaking here.
Blocks: LSan
Component: General → Video/Audio
Might this be related to bug 1065827 comment 76? jya has been looking at some memory leaks here.
Flags: needinfo?(jyavenard)
Flags: needinfo?(jwwang)
They look to be the same yes..

Should be fixed once bug 1065827 lands.
Flags: needinfo?(jyavenard)
It might be more clear to move the patch fixing leaks here which you just happened to hit on the way fixing bug 1065827.
Flags: needinfo?(jwwang)
(In reply to JW Wang [:jwwang] from comment #5)
> It might be more clear to move the patch fixing leaks here which you just
> happened to hit on the way fixing bug 1065827.

Yes, we could ...
(In reply to JW Wang [:jwwang] from comment #5)
> It might be more clear to move the patch fixing leaks here which you just
> happened to hit on the way fixing bug 1065827.

Yes, we could ... 

Adding dependency to bug 1065827, as the patch is based on code with 1065827 applied
Depends on: 1065827
Move patch from bug 1065827
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Rebase following change of patch order
Attachment #8517961 - Attachment is obsolete: true
Keywords: checkin-needed
this patch failed to apply:

applying 1093654_fix_leaks.patch
patching file dom/media/AbstractMediaDecoder.h
Hunk #1 FAILED at 82
Hunk #2 FAILED at 148
2 out of 2 hunks FAILED -- saving rejects to file dom/media/AbstractMediaDecoder.h.rej
patching file dom/media/MediaDecoder.cpp
Hunk #2 FAILED at 708
1 out of 2 hunks FAILED -- saving rejects to file dom/media/MediaDecoder.cpp.rej
patching file dom/media/MediaDecoder.h
Hunk #2 FAILED at 782
1 out of 2 hunks FAILED -- saving rejects to file dom/media/MediaDecoder.h.rej
patching file dom/media/MediaDecoderStateMachine.cpp
Hunk #1 FAILED at 2042
Hunk #2 FAILED at 2158
2 out of 3 hunks FAILED -- saving rejects to file dom/media/MediaDecoderStateMachine.cpp.rej
patching file dom/media/MediaMetadataManager.h
Hunk #1 FAILED at 47
1 out of 1 hunks FAILED -- saving rejects to file dom/media/MediaMetadataManager.h.rej
patching file dom/media/mediasource/SourceBufferDecoder.cpp
Hunk #1 FAILED at 84
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasource/SourceBufferDecoder.cpp.rej
patching file dom/media/mediasource/SourceBufferDecoder.h
Hunk #1 FAILED at 41
1 out of 1 hunks FAILED -- saving rejects to file dom/media/mediasource/SourceBufferDecoder.h.rej
patching file dom/media/omx/MediaOmxCommonDecoder.cpp
Hunk #1 FAILED at 51
1 out of 1 hunks FAILED -- saving rejects to file dom/media/omx/MediaOmxCommonDecoder.cpp.rej
patching file dom/media/omx/MediaOmxCommonDecoder.h
Hunk #1 FAILED at 17
1 out of 1 hunks FAILED -- saving rejects to file dom/media/omx/MediaOmxCommonDecoder.h.rej
patching file dom/media/webaudio/BufferDecoder.cpp
Hunk #1 FAILED at 134
1 out of 1 hunks FAILED -- saving rejects to file dom/media/webaudio/BufferDecoder.cpp.rej
patching file dom/media/webaudio/BufferDecoder.h
Hunk #1 FAILED at 52
1 out of 1 hunks FAILED -- saving rejects to file dom/media/webaudio/BufferDecoder.h.rej
patch failed, unable to continue (try -v)


could you take a look, thanks!
Flags: needinfo?(jyavenard)
Keywords: checkin-needed
this patch depends on bug 1065827 being applied
Flags: needinfo?(jyavenard)
sorry had to back this out since bug 1065827 needed to be backed out
Keywords: checkin-needed
OS: Linux → All
Hardware: x86 → All
Whiteboard: must be applied after 1065827
https://hg.mozilla.org/mozilla-central/rev/f6e450faa7a2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: