Driver version mismatch should blacklist any graphics features

RESOLVED FIXED in Firefox 33

Status

()

Core
Graphics
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: bas, Assigned: bas)

Tracking

unspecified
mozilla36
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(firefox33+ fixed, firefox34+ fixed, firefox35+ fixed, firefox36+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We're currently blocking an arbitrary bunch of graphics features when there's driver mismatches. We should block all of them since we really have no idea what driver is installed.
(Assignee)

Comment 1

3 years ago
Created attachment 8516785 [details] [diff] [review]
Don't allow any features when there's a driver version mismatch
Attachment #8516785 - Flags: review?(jmuizelaar)
Attachment #8516785 - Flags: review?(jmuizelaar) → review+
Jeff, Bas, could you land this patch and ask for the uplift requests? Thanks
status-firefox33: --- → affected
status-firefox34: --- → affected
status-firefox35: --- → affected
status-firefox36: --- → affected
tracking-firefox33: --- → +
tracking-firefox34: --- → +
tracking-firefox35: --- → +
tracking-firefox36: --- → +
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(bas)
https://hg.mozilla.org/mozilla-central/rev/650e884887f5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox36: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment on attachment 8516785 [details] [diff] [review]
Don't allow any features when there's a driver version mismatch

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Some users with driver mismatch fallback to D3D9 even though we don't know if their driver can handle D3D9 propely (due to the fact that we can't tell what driver they have). As a result some user can endup with unsupported configurations such as D2D+D3D9 or D3D9 outside of windows xp.
[Describe test coverage new/current, TBPL]: None.
[Risks and why]: very low, it gets user with unknown configuration (driver version mismatch) to software rendering which is the safest place they can be.
[String/UUID change made/needed]: None.
Attachment #8516785 - Flags: approval-mozilla-release?
Attachment #8516785 - Flags: approval-mozilla-beta?
Attachment #8516785 - Flags: approval-mozilla-aurora?
Attachment #8516785 - Flags: approval-mozilla-release?
Attachment #8516785 - Flags: approval-mozilla-release+
Attachment #8516785 - Flags: approval-mozilla-beta?
Attachment #8516785 - Flags: approval-mozilla-beta+
Attachment #8516785 - Flags: approval-mozilla-aurora?
Attachment #8516785 - Flags: approval-mozilla-aurora+
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(bas)
We need it in GECKO331_2014103013_RELBRANCH too.
thanks
https://hg.mozilla.org/releases/mozilla-aurora/rev/cbcbc189bf96
https://hg.mozilla.org/releases/mozilla-beta/rev/38b0e08b93b7
https://hg.mozilla.org/releases/mozilla-release/rev/fea32fee2c45
https://hg.mozilla.org/releases/mozilla-release/rev/e1414483567c
status-firefox33: affected → fixed
status-firefox34: affected → fixed
status-firefox35: affected → fixed
Also landed on GECKO330_2014101104_RELBRANCH for 33.0.3:
https://hg.mozilla.org/releases/mozilla-release/rev/7311ad1fba8c
This unintentionally blocked all acceleration on Windows XP on Intel hardware.
(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)
> This unintentionally blocked all acceleration on Windows XP on Intel
> hardware.

Which then got "fixed" with bug 1141783.
You need to log in before you can comment on or make changes to this bug.