1093695 - Gip on B2G Desktop Linux x64 debug tests run the wrong manifest file

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Zac C (:zac)]

Previously these tests were perma-red and hidden.

I've just noticed that not only are they red but now are running 0 tests because they're using a since obsoleted (by the chunking change bug 1046694) manifest file.

I guess that the error begins here as I can see that the correct command line options are not passed in when marionette.py is executed in the job:
http://hg.mozilla.org/build/buildbot-configs/file/c0e8b1331bbc/mozilla-tests/b2g_config.py#l829

We should update this job to use the chunking and at least from there we can try and get it green again.

Comment 1

[Zac C (:zac)]

Simone, can help with this at all?

I can compile the patch but I need to confirm the source of the problem first.

Comment 2

[Zac C (:zac)]

Jgriffin, can you advise me on how to modify this job's configuration to use the split Gip(a, f1, etc) chunking workflow?

I've run the tests locally and I don't see any reason why this job shouldn't run the same configuration as non-debug nor be green with a little bit of work.

I'll start from there and if I can get it at least running tests I can then tune the configuration/disable tests as required.

Comment 3

[Jonathan Griffin (:jgriffin)]

This occurs because of this block of code:

http://hg.mozilla.org/build/buildbot-configs/file/c0e8b1331bbc/mozilla-tests/b2g_config.py#l2178

We're using the old, non-chunked Gip on older branches.  If it's safe to run those on older branches, we could tweak b2g_config.py to use the new chunks everywhere.  If you'd like me to do this, needinfo me again.

Comment 4

[Zac C (:zac)]

(In reply to Jonathan Griffin (:jgriffin) from comment #3)
> This occurs because of this block of code:
> 
> http://hg.mozilla.org/build/buildbot-configs/file/c0e8b1331bbc/mozilla-tests/
> b2g_config.py#l2178
> 
> We're using the old, non-chunked Gip on older branches.  If it's safe to run
> those on older branches, we could tweak b2g_config.py to use the new chunks
> everywhere.  If you'd like me to do this, needinfo me again.

No I don't think it's safe. we should only use chunks on gecko36/v2.2+.

However gecko36/v2.2 and linux64 debug is definitely not running the chunks, whereas non-debug is and that's the bit I want to resolve. Working backwards from what I see in the TBPL job and through the marionette.py script I suppose that in b2g_config.py, debug platform is just picking up non-chunk workflow.

It shouldn't matter whether it's debug or non-debug build (at least at this level of configuration).

Can you make linux64 debug use chunking, but only on b2g36/v2.2?

Comment 5

[Jonathan Griffin (:jgriffin)]

Should be an easy enough fix; I'll try to get it working this week.

Comment 6

[Jonathan Griffin (:jgriffin)]

Attachment: Split Gip on debug linux64_gecko,

Chunk gip on linux64_debug like we do for opt, r=jlund

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8531773 [details] [diff] [review]
Split Gip on debug linux64_gecko,

cool, lgtm

branches affected:

try
jamun
cypress
alder
pine
b2g-inbound
gaia-try
cedar
mozilla-central
ash
mozilla-inbound
fx-team

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8531773 [details] [diff] [review]
Split Gip on debug linux64_gecko,

Review of attachment 8531773 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbot-configs/rev/cd4d8fbebd25

Comment 9

[Zac C (:zac)]

When this lands in prod, Dave is going to check it's running the correct configuration and then delegate getting the suite back to green.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It looks like this may be resolved now. The tests are now failing due to crashes.

Comment 11

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/cd4d8fbebd25

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Marking as resolved. The failures will be dealt with separately.