Closed Bug 1093741 Opened 10 years ago Closed 9 years ago

Update the minimum Windows version for the 64-bit installer to win7/64

Categories

(Firefox :: Installer, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 36

People

(Reporter: benjamin, Assigned: emk, Mentored)

References

Details

(Whiteboard: [good first bug][lang=NSIS])

Attachments

(1 file, 1 obsolete file)

Per bug 604967, we're going to bump the minimum supported Windows version for Firefox/64bit to Windows 7. The existing installer code which checks the version should be updated.

rstrong this is not a high priority, but could you link to the existing version-check in the source and mentor a contributor through this?
Flags: needinfo?(robert.strong.bugs)
Depends on: 604967
Sure though this would take me all of 15 minutes.
Flags: needinfo?(robert.strong.bugs)
That's how good first bugs always are.
Mentor: robert.strong.bugs
Whiteboard: [good first bug][lang=NSIS]
Already understood though when it comes to getting people to work on code other than javascript, c, c++, etc. the chances of the person continuing to contribute has been significantly even smaller than with our other code so the effort to value ratio is even worse. I'll do as you asked of course... just want this reality understood vs. ignored.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8528349 - Flags: review?(robert.strong.bugs)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #5)
> Comment on attachment 8528349 [details] [diff] [review]
> Thanks! Please change the following as well.
> http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/
> stub.nsi#316
That one has already been in the patch. Did you mean a different line of code?
The former was already in the patch. I added the latter.
Attachment #8528349 - Attachment is obsolete: true
Attachment #8529016 - Flags: review?(robert.strong.bugs)
Comment on attachment 8529016 [details] [diff] [review]
Refuse install Firefox on pre-Win7 x64, v2

Thanks!
Attachment #8529016 - Flags: review?(robert.strong.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c8839443b511
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Target Milestone: Firefox 37 → Firefox 36
Hello,

Just curious is there a check or block going to be added to Firefox.exe itself as a user can just extract the installer with 7zip and run the browser or run it in portable format.
The 64-bit Firefox.exe itself will no longer run on older operating systems than Windows 7 since bug 1094013. BTW Firefox.exe itself has no checks. The operating system is the one that checks the subsystem version of the executable.
You need to log in before you can comment on or make changes to this bug.