1093868 - Markdown text rendering in comments is broken after commit from bug 1059684

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[David Lawrence [:dkl]]

Moved from bug 1059684

This patch committed in bug 1059684 has a few critical flaws that need to be resolved:

1) It breaks "bug xyz" and "bugs 1, 2" auto-linkfications
2) It makes Markdown comments look with a different font
3) and it also makes inline spacing in Markdown comments bigger since there is no any class defined for <p>.

Comment 1

[:glob ✱]

(In reply to David Lawrence [:dkl] from comment #0)
> 2) It makes Markdown comments look with a different font

this isn't a bug.  one of the main benefits of switching to markdown is moving away from a monospaced font.

Comment 2

[Albert Ting]

Attachment: v1

I'm trying to use Markdown for 5.0 and #1 is blocking me.  #3 is a minor issue and suggest moving it to a separate ticket.

For #1, a quick patch is to revert back to the original code, where it only replaces newlines with two trailing spaces.  That fixes my issue

Comment 3

[Albert Ting]

Attachment: v2

While the v1 patch worked, it doesn't allow you to embed bug_links in markdown constructs, such as headers.  

v2 patch, where I remove new lines from all bug_links.  I had to hack it a bit, I escape '|' in the titles as it confused markdown tables.  There's probably a better way to do that but it works.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8576198 [details] [diff] [review]
v2

Review of attachment 8576198 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 5

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   f293fdf..1fbcede  master -> master