Closed
Bug 1093905
Opened 10 years ago
Closed 10 years ago
Punctuation missing from the fxa banner
Categories
(Marketplace Graveyard :: General, defect, P4)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: krupa.mozbugs, Assigned: pwalm)
References
Details
steps to reproduce: 1. Notice the FxA banner on https://marketplace.allizom.org/ expected behavior: There should be periods separating the sentences. actual behavior: "Firefox Accounts has arrived Learn how to transfer your account It's easy." is not very readable without periods. screenshot: https://www.dropbox.com/s/9c81et1yw3jlx85/Screenshot%202014-11-04%2014.55.12.png?dl=0
Comment 1•10 years ago
|
||
Bear in mind any changes at this point cause localisation changes.
Assignee: nobody → pwalmsley
Updated•10 years ago
|
Priority: -- → P4
Assignee | ||
Comment 2•10 years ago
|
||
lol actual vs expected What happened to the periods?!
Comment 3•10 years ago
|
||
(In reply to Philip from comment #2) > lol > > actual vs expected > > What happened to the periods?! So just put periods there? Link to original mocks?
Comment 4•10 years ago
|
||
Chatting to pwalm, he doesn't think this is an issue and is implemented as per the mock.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Comment 5•10 years ago
|
||
PRs: https://github.com/mozilla/zamboni/pull/2726 https://github.com/mozilla/fireplace/pull/791
You need to log in
before you can comment on or make changes to this bug.
Description
•