Closed Bug 1093929 Opened 11 years ago Closed 11 years ago

Improve grunt tasks and add additional options

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: oteo, Assigned: dcoloma)

References

Details

(Whiteboard: [mobile app][[loop approved for 1.1][loop in v1.1])

Attachments

(1 file)

Link to Github pull-request
61 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review
Now that grunt is used to create Loop builds, it would be good to use it to allow the app to be created with different options: - Debug on/off - Loop Server to be used - Metrics on/off - Performance log on/off - Enforce device compatibility on/off ... and allow it to be used on non git repos (e.g. zip files with app source code) and do all the changes in the app in a "build" folder instead of doing them on top of the source folder.
Assignee: nobody → oteo
Status: NEW → ASSIGNED
Attachment #8517060 - Flags: review?(josea.olivera)
Assignee: oteo → dcoloma
Blocks: Loopmov_1_1
Whiteboard: [mobile app][[loop approved for 1.1]
Looking really good. I left a few nits, requests and questions on the PR so could you have a look please? Once everything gets addressed we will be ready to land. Thanks!
(In reply to José Antonio Olivera Ortega [:jaoo] PTO till 11/24 from comment #2) > Looking really good. I left a few nits, requests and questions on the PR so > could you have a look please? Once everything gets addressed we will be > ready to land. Thanks! Thanks for your time! I've just updated the PR addressing your comments. Let me know if there is anything still missing. Thanks!
Comment on attachment 8517060 [details] [review] Link to Github pull-request LGTM. r=me Left the last comments on the PR. Address them before landing please. Thanks for taking care of it.
Attachment #8517060 - Flags: review?(josea.olivera) → review+
(In reply to José Antonio Olivera Ortega [:jaoo] PTO till 11/24 from comment #4) > Comment on attachment 8517060 [details] [review] > Link to Github pull-request > > LGTM. r=me > > Left the last comments on the PR. Address them before landing please. Thanks > for taking care of it. I think I've address all your comments, in the updated PR. I'll test the changes tomorrow before landing. Thanks!
Merged in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/76d82cb8da5424be64688c731910ce6eceb2e3fd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [mobile app][[loop approved for 1.1] → [mobile app][[loop approved for 1.1][loop not in v1.1]
Merged in v1.1 branch: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d445ea92d27c97f24f99124eafd75c35ea5fb1ea
Whiteboard: [mobile app][[loop approved for 1.1][loop not in v1.1] → [mobile app][[loop approved for 1.1][loop in v1.1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: