Improve grunt tasks and add additional options

RESOLVED FIXED

Status

Firefox OS
Gaia::Loop
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: oteo, Assigned: dcoloma)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobile app][[loop approved for 1.1][loop in v1.1])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Now that grunt is used to create Loop builds, it would be good to use it to allow the app to be created with different options:

 - Debug on/off
 - Loop Server to be used
 - Metrics on/off
 - Performance log on/off
 - Enforce device compatibility on/off

... and allow it to be used on non git repos (e.g. zip files with app source code) and do all the changes in the app in a "build" folder instead of doing them on top of the source folder.
(Reporter)

Comment 1

3 years ago
Created attachment 8517060 [details] [review]
Link to Github pull-request
Assignee: nobody → oteo
Status: NEW → ASSIGNED
Attachment #8517060 - Flags: review?(josea.olivera)
(Reporter)

Updated

3 years ago
Assignee: oteo → dcoloma
(Reporter)

Updated

3 years ago
Blocks: 988276
(Reporter)

Updated

3 years ago
Whiteboard: [mobile app][[loop approved for 1.1]
Looking really good. I left a few nits, requests and questions on the PR so could you have a look please? Once everything gets addressed we will be ready to land. Thanks!
(Assignee)

Comment 3

3 years ago
(In reply to José Antonio Olivera Ortega [:jaoo] PTO till 11/24 from comment #2)
> Looking really good. I left a few nits, requests and questions on the PR so
> could you have a look please? Once everything gets addressed we will be
> ready to land. Thanks!

Thanks for your time! I've just updated the PR addressing your comments. Let me know if there is anything still missing.

Thanks!
Comment on attachment 8517060 [details] [review]
Link to Github pull-request

LGTM. r=me

Left the last comments on the PR. Address them before landing please. Thanks for taking care of it.
Attachment #8517060 - Flags: review?(josea.olivera) → review+
(Assignee)

Comment 5

3 years ago
(In reply to José Antonio Olivera Ortega [:jaoo] PTO till 11/24 from comment #4)
> Comment on attachment 8517060 [details] [review]
> Link to Github pull-request
> 
> LGTM. r=me
> 
> Left the last comments on the PR. Address them before landing please. Thanks
> for taking care of it.

I think I've address all your comments, in the updated PR. I'll test the changes tomorrow before landing. Thanks!
(Assignee)

Comment 6

3 years ago
Merged in master: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/76d82cb8da5424be64688c731910ce6eceb2e3fd
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Reporter)

Updated

3 years ago
Whiteboard: [mobile app][[loop approved for 1.1] → [mobile app][[loop approved for 1.1][loop not in v1.1]
(Reporter)

Comment 7

3 years ago
Merged in v1.1 branch: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/d445ea92d27c97f24f99124eafd75c35ea5fb1ea
Whiteboard: [mobile app][[loop approved for 1.1][loop not in v1.1] → [mobile app][[loop approved for 1.1][loop in v1.1]
You need to log in before you can comment on or make changes to this bug.