Closed
Bug 1093998
Opened 11 years ago
Closed 10 years ago
Make nsContainerFrame::CreateNextInFlow return the frame pointer
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: xidorn, Assigned: xidorn)
Details
Attachments
(1 file)
|
8.25 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Per bug 1052924 comment 58, nsContainerFrame::CreateNextInFlow should return the frame pointer instead of returning nsresult and using an out-parameter, since it never returns anything other than NS_OK.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8530022 -
Flags: review?(dbaron)
Comment on attachment 8530022 [details] [diff] [review]
patch
This patch needs a commit message. I suggest:
Bug 1093998 - Make nsContainerFrame::CreateNextInFlow return the new frame instead of using an out param. r=dbaron
r=dbaron with that
Attachment #8530022 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3b81f1a9cfd1
m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d1eff75ad60
Solve unused variable errors in addition.
Assignee: nobody → quanxunzhen
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•