Closed Bug 1094012 Opened 5 years ago Closed 5 years ago

IsWin7OrLater() and friends should always return true on Win64

Categories

(Core :: MFBT, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

The optimizer will be able to eliminate some dead code.
Try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c88856f6fd69

This patch will reduce the full installer size by 13KB.
Attachment #8517401 - Flags: review?(jmathies)
Shouldn't we return false for the < win7 checks?
All check functions will check if WinXX "or later". Win7 is XPSP3 or later, Win2003 or later, and Vista or later.
We need to make sure that the Win64 binary will never run on Vista or earlier.
Depends on: 1094013
Comment on attachment 8517401 [details] [diff] [review]
Assume Win7 or later on Win64

(In reply to Masatoshi Kimura [:emk] from comment #3)
> All check functions will check if WinXX "or later". Win7 is XPSP3 or later,
> Win2003 or later, and Vista or later.

Ah yes, ok looks good.
Attachment #8517401 - Flags: review?(jmathies) → review+
Assignee: nobody → VYV03354
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb866db7ae0e
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/fb866db7ae0e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.