1094012 - IsWin7OrLater() and friends should always return true on Win64

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Masatoshi Kimura [:emk]]

The optimizer will be able to eliminate some dead code.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Assume Win7 or later on Win64

Try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c88856f6fd69

This patch will reduce the full installer size by 13KB.

Comment 2

[Jim Mathies [:jimm]]

Shouldn't we return false for the < win7 checks?

Comment 3

[Masatoshi Kimura [:emk]]

All check functions will check if WinXX "or later". Win7 is XPSP3 or later, Win2003 or later, and Vista or later.

Comment 4

[Masatoshi Kimura [:emk]]

We need to make sure that the Win64 binary will never run on Vista or earlier.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8517401 [details] [diff] [review]
Assume Win7 or later on Win64

(In reply to Masatoshi Kimura [:emk] from comment #3)
> All check functions will check if WinXX "or later". Win7 is XPSP3 or later,
> Win2003 or later, and Vista or later.

Ah yes, ok looks good.

Comment 6

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fb866db7ae0e

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fb866db7ae0e