Closed
Bug 1094016
Opened 10 years ago
Closed 9 years ago
Stop shipping d3dcompiler_43 for Win64
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
5.64 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
We have to ship this only for WinXP that we no longer support on Win64.
Assignee | ||
Comment 1•10 years ago
|
||
Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=65713bdf0fba This patch will reduce the full installer size by 610KB.
Assignee: nobody → VYV03354
Attachment #8517402 -
Flags: review?(mshal)
Comment 2•10 years ago
|
||
Comment on attachment 8517402 [details] [diff] [review] Do not ship d3dcompiler_43 for 64-bit builds It would be nice to see other Windows builds in the try run as well. If d3dcompiler_43.dll isn't valid on 64-bit builds, do we need to conditionally add it to ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES in gfx/angle/src/libGLESv2/moz.build? Right now it is added for all builds.
Attachment #8517402 -
Flags: review?(mshal) → review+
Assignee | ||
Comment 3•10 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #2) > Comment on attachment 8517402 [details] [diff] [review] > Do not ship d3dcompiler_43 for 64-bit builds > > It would be nice to see other Windows builds in the try run as well. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b7a4d6025951 > If d3dcompiler_43.dll isn't valid on 64-bit builds, do we need to > conditionally add it to ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES in > gfx/angle/src/libGLESv2/moz.build? Right now it is added for all builds. We do not need this. Extra items in this array are benign. For example, we will never ship both d3dcompiler_47 and d3dcompiler_46. It is not a trivial change to make it conditional, so I'm leaving it for now.
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79585cab774
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/b79585cab774
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment 6•9 years ago
|
||
This goes as far as to break 64-bit builds using the 7.0 SDK, was this the intent?
Assignee | ||
Comment 7•9 years ago
|
||
No, forgot about Win7 SDK.
Assignee | ||
Comment 8•9 years ago
|
||
That said, I'm not sure we should fix this because bug 1084056 is planned for Gecko 37.
Updated•9 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•