1094016 - Stop shipping d3dcompiler_43 for Win64

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Masatoshi Kimura [:emk]]

We have to ship this only for WinXP that we no longer support on Win64.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Do not ship d3dcompiler_43 for 64-bit builds

Try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=65713bdf0fba

This patch will reduce the full installer size by 610KB.

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8517402 [details] [diff] [review]
Do not ship d3dcompiler_43 for 64-bit builds

It would be nice to see other Windows builds in the try run as well.

If d3dcompiler_43.dll isn't valid on 64-bit builds, do we need to conditionally add it to ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES in gfx/angle/src/libGLESv2/moz.build? Right now it is added for all builds.

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8517402 [details] [diff] [review]
> Do not ship d3dcompiler_43 for 64-bit builds
> 
> It would be nice to see other Windows builds in the try run as well.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b7a4d6025951

> If d3dcompiler_43.dll isn't valid on 64-bit builds, do we need to
> conditionally add it to ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES in
> gfx/angle/src/libGLESv2/moz.build? Right now it is added for all builds.

We do not need this. Extra items in this array are benign. For example, we will never ship both d3dcompiler_47 and d3dcompiler_46.
It is not a trivial change to make it conditional, so I'm leaving it for now.

Comment 4

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b79585cab774

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b79585cab774

Comment 6

[[e-mail]]

This goes as far as to break 64-bit builds using the 7.0 SDK, was this the intent?

Comment 7

[Masatoshi Kimura [:emk]]

No, forgot about Win7 SDK.

Comment 8

[Masatoshi Kimura [:emk]]

That said, I'm not sure we should fix this because bug 1084056 is planned for Gecko 37.