Closed Bug 1094016 Opened 6 years ago Closed 6 years ago

Stop shipping d3dcompiler_43 for Win64

Categories

(Core :: Canvas: WebGL, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

We have to ship this only for WinXP that we no longer support on Win64.
Try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=65713bdf0fba

This patch will reduce the full installer size by 610KB.
Assignee: nobody → VYV03354
Attachment #8517402 - Flags: review?(mshal)
Comment on attachment 8517402 [details] [diff] [review]
Do not ship d3dcompiler_43 for 64-bit builds

It would be nice to see other Windows builds in the try run as well.

If d3dcompiler_43.dll isn't valid on 64-bit builds, do we need to conditionally add it to ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES in gfx/angle/src/libGLESv2/moz.build? Right now it is added for all builds.
Attachment #8517402 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8517402 [details] [diff] [review]
> Do not ship d3dcompiler_43 for 64-bit builds
> 
> It would be nice to see other Windows builds in the try run as well.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b7a4d6025951

> If d3dcompiler_43.dll isn't valid on 64-bit builds, do we need to
> conditionally add it to ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES in
> gfx/angle/src/libGLESv2/moz.build? Right now it is added for all builds.

We do not need this. Extra items in this array are benign. For example, we will never ship both d3dcompiler_47 and d3dcompiler_46.
It is not a trivial change to make it conditional, so I'm leaving it for now.
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79585cab774
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/b79585cab774
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
This goes as far as to break 64-bit builds using the 7.0 SDK, was this the intent?
No, forgot about Win7 SDK.
That said, I'm not sure we should fix this because bug 1084056 is planned for Gecko 37.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.