Closed
Bug 1094029
Opened 10 years ago
Closed 10 years ago
invalid test/os/branch should not cause graphserver to fall over
Categories
(Webtools Graveyard :: Graph Server, defect)
Webtools Graveyard
Graph Server
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rhelmer, Assigned: rhelmer)
References
Details
Attachments
(1 file)
|
1.47 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•10 years ago
|
Summary: invalid test/os/branch → invalid test/os/branch should not cause graphserver to fall over
|
|
Assignee | |
Comment 1•10 years ago
|
||
See bug 1093944 for context - some bad data was inserted somewhere that's causing getTestOptions() in api.py to fail. This is simple to guard against, but we should log a warning when it happens so we can track down problems.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Bad data is bad, but graph server should just log these and ignore rather than just falling over.
Attachment #8517209 -
Flags: review?(jmaher)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8517209 [details] [diff] [review] guard against missing data in test combos Review of attachment 8517209 [details] [diff] [review]: ----------------------------------------------------------------- this looks much better than what was there previously
Attachment #8517209 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Landed in http://hg.mozilla.org/graphs/rev/e2cc529de8a4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•