invalid test/os/branch should not cause graphserver to fall over

RESOLVED FIXED

Status

Webtools Graveyard
Graph Server
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 years ago
Summary: invalid test/os/branch → invalid test/os/branch should not cause graphserver to fall over
(Assignee)

Comment 1

4 years ago
See bug 1093944 for context - some bad data was inserted somewhere that's causing getTestOptions() in api.py to fail. This is simple to guard against, but we should log a warning when it happens so we can track down problems.
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
Created attachment 8517209 [details] [diff] [review]
guard against missing data in test combos

Bad data is bad, but graph server should just log these and ignore rather than just falling over.
Attachment #8517209 - Flags: review?(jmaher)
Comment on attachment 8517209 [details] [diff] [review]
guard against missing data in test combos

Review of attachment 8517209 [details] [diff] [review]:
-----------------------------------------------------------------

this looks much better than what was there previously
Attachment #8517209 - Flags: review?(jmaher) → review+
(Assignee)

Comment 4

4 years ago
Landed in http://hg.mozilla.org/graphs/rev/e2cc529de8a4
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 1094308
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.