1094089 - [Telephony] Marionette Test: Refactoring the promise usage in head.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: (WIP) Refactoring telephony marionette head.js

Try to make it clear.
Ongoing, still need to work on conference part.

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Show reject cause

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: Refactoring the promise usage in head.js

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 3: Rewrite test_outgoing_radio_off.js

Comment 5

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8518822 [details] [diff] [review]
Part 2: Refactoring the promise usage in head.js

Review of attachment 8518822 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you!

::: dom/telephony/test/marionette/head.js
@@ +124,5 @@
> +   * @param aTarget
> +   *        A event target.
> +   * @param aEventName
> +   *        A string event name.
> +   * @param aPreficate [optional]

s/aPreficate/aPredicate

@@ +125,5 @@
> +   *        A event target.
> +   * @param aEventName
> +   *        A string event name.
> +   * @param aPreficate [optional]
> +   *        A preficate function, resolve the promise if aPreficate(event)

ditto.

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

> > +   * @param aPreficate [optional]
> 
> s/aPreficate/aPredicate
> 
> > +   *        A preficate function, resolve the promise if aPreficate(event)
> 
> ditto.

Interesting... Did I just type the wrong key for three times?

Comment 7

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #6)
> > > +   * @param aPreficate [optional]
> > 
> > s/aPreficate/aPredicate
> > 
> > > +   *        A preficate function, resolve the promise if aPreficate(event)
> > 
> > ditto.
> 
> Interesting... Did I just type the wrong key for three times?

I tried so hard to figure out how that happened when I was doing the review :P

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 1: Show reject cause. r=hsinyi

Comment 9

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 2: Refactoring the promise usage in head.js. r=hsinyi

Comment 10

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Part 3: Rewrite test_outgoing_radio_off.js. r=hsinyi

Comment 11

[Szu-Yu Chen [:aknow] (inactive)]

try looks good
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=77c3956fb0f4

Comment 12

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/40bafa024fa5
https://hg.mozilla.org/integration/b2g-inbound/rev/173a19934612
https://hg.mozilla.org/integration/b2g-inbound/rev/8a1d3a5b5668

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40bafa024fa5
https://hg.mozilla.org/mozilla-central/rev/173a19934612
https://hg.mozilla.org/mozilla-central/rev/8a1d3a5b5668