Closed Bug 1094142 Opened 7 years ago Closed 7 years ago

[STK] The data format of confirmMessage/callMessage from SET_UP_CALL/LAUNCH_BROWSER is not complied to the definition in MozStkCommandEvent.webidl

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S9 (21Nov)

People

(Reporter: bevis, Assigned: bevis)

References

Details

Attachments

(1 file)

In bug 1091454 comment 4, to support icon properly for SET_UP_CALL/LAUNCH_BROWSER, we should treat confirmMessage/callMessage as a container(MozStkTextMessage) of the text/icon to be displayed instead of a DOMString.

File this bug to have the backward-compatibility of confirmMessage/callMessage for DOMString/MozStkTextMessage.
Due to the icon support for SET_UP_CALL/LAUNCH_BROWSER to be done in Bug 1091454, we'd like to reuse confirmMessage/callMessage by changing its data type from DOMString to MozStkTextMessage, where MozStkTextMessage is defined a container for both text/icons.

Hence, this patch is required to prevent function broken after the patches of Bug 1091454 is landed.

Hi Fernando,

May I have your review for this change?

Thanks!
Attachment #8518792 - Flags: review?(frsela)
Comment on attachment 8518792 [details] [review]
PR: Support DOMString/MozStkTextMessage for confirmMessage/callMessage in SET_UP_CALL/LAUNCH_BROWSER. r=frsela

LGTM
Attachment #8518792 - Flags: review?(frsela) → review+
https://github.com/mozilla-b2g/gaia/commit/14fb72cfa10432624d1b5e2e58dd8584cd05968c
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in before you can comment on or make changes to this bug.