Closed Bug 1094142 Opened 7 years ago Closed 7 years ago
[STK] The data format of confirm
Message/call Message from SET _UP _CALL/LAUNCH _BROWSER is not complied to the definition in Moz Stk Command Event .webidl
PR: Support DOMString/MozStkTextMessage for confirmMessage/callMessage in SET_UP_CALL/LAUNCH_BROWSER. r=frsela
46 bytes, text/x-github-pull-request
|Details | Review|
In bug 1091454 comment 4, to support icon properly for SET_UP_CALL/LAUNCH_BROWSER, we should treat confirmMessage/callMessage as a container(MozStkTextMessage) of the text/icon to be displayed instead of a DOMString. File this bug to have the backward-compatibility of confirmMessage/callMessage for DOMString/MozStkTextMessage.
Due to the icon support for SET_UP_CALL/LAUNCH_BROWSER to be done in Bug 1091454, we'd like to reuse confirmMessage/callMessage by changing its data type from DOMString to MozStkTextMessage, where MozStkTextMessage is defined a container for both text/icons. Hence, this patch is required to prevent function broken after the patches of Bug 1091454 is landed. Hi Fernando, May I have your review for this change? Thanks!
Attachment #8518792 - Flags: review?(frsela)
Comment on attachment 8518792 [details] [review] PR: Support DOMString/MozStkTextMessage for confirmMessage/callMessage in SET_UP_CALL/LAUNCH_BROWSER. r=frsela LGTM
Attachment #8518792 - Flags: review?(frsela) → review+
update try server result: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=8373a2164842
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
You need to log in before you can comment on or make changes to this bug.