1094142 - [STK] The data format of confirmMessage/callMessage from SET_UP_CALL/LAUNCH_BROWSER is not complied to the definition in MozStkCommandEvent.webidl

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

In bug 1091454 comment 4, to support icon properly for SET_UP_CALL/LAUNCH_BROWSER, we should treat confirmMessage/callMessage as a container(MozStkTextMessage) of the text/icon to be displayed instead of a DOMString.

File this bug to have the backward-compatibility of confirmMessage/callMessage for DOMString/MozStkTextMessage.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: PR: Support DOMString/MozStkTextMessage for confirmMessage/callMessage in SET_UP_CALL/LAUNCH_BROWSER. r=frsela

Due to the icon support for SET_UP_CALL/LAUNCH_BROWSER to be done in Bug 1091454, we'd like to reuse confirmMessage/callMessage by changing its data type from DOMString to MozStkTextMessage, where MozStkTextMessage is defined a container for both text/icons.

Hence, this patch is required to prevent function broken after the patches of Bug 1091454 is landed.

Hi Fernando,

May I have your review for this change?

Thanks!

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 8518792 [details] [review]
PR: Support DOMString/MozStkTextMessage for confirmMessage/callMessage in SET_UP_CALL/LAUNCH_BROWSER. r=frsela

LGTM

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

update try server result:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=8373a2164842

Comment 4

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/14fb72cfa10432624d1b5e2e58dd8584cd05968c