Closed Bug 1094190 Opened 10 years ago Closed 9 years ago

[Commit hook] We should not exit when gjslint is absent

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: julienw, Unassigned, Mentored)

Details

(Whiteboard: [lang=sh]) 

Currently, when gjslint is absent, we simply exit the hook. This is IMO incorrect and we should only skip gjslint checks.
Let's make this a mentored bug and see if anybody is interested.

In this bug I'm also interested to make the commit hook a little more organized. Especially I'd like a separate function for each check.

The code lives in "tools/pre-commit" and is installed in the correct place by the Makefile goal ".git/hooks/pre-commit". That means that the hook can be installed even when we're in an older branch, that's why we check that some files are here before running some checks.

We also need to take care that this works both on MacOS X and Linux.
Mentor: felash
Whiteboard: [lang=sh]
Gjslint is gone!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.