1094240 - e10s - disabling the findbar using "disablefastfind" is broken (therefore causes test failures in browser_zbug569342.js)

Status: NEW

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

34 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find bar should not be visible - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindDisabled/<:65
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
null:null:0
35 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find command should be disabled - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindDisabled/<:66
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
null:null:0
36 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find bar should not be visible - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindDisabled/<:65
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
null:null:0
37 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find command should be disabled - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindDisabled/<:66
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
null:null:0
38 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find bar should not be visible - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindDisabled/<:65
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
null:null:0
39 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find command should be disabled - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindDisabled/<:66
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
null:null:0
40 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js | Find bar should now be hidden - 
Stack trace:
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:testFindEnabled/<:83
chrome://mochitests/content/browser/browser/base/content/test/general/browser_zbug569342.js:load/<:23
resource://gre/modules/RemoteAddonsParent.jsm:EventTargetParent.dispatch:485
resource://gre/modules/RemoteAddonsParent.jsm:EventTargetParent.receiveMessage:457
null:null:0
SUITE-END | took 4s

Comment 1

[Chris Peterson [:cpeterson]]

e10s test bugs block e10s, but not a particular milestone.

Comment 2

[Steffen Wilberg]

Bug 569342 introduced the "disablefastfind" attribute.
MDN says:
"Put disablefastfind="true" on the root element of a XUL document, which is intended to be loaded in a tab, to disable the find bar for the tab with this document. This is used to prevent the find bar from being displayed when it's not supported by the content (such as in the Add-ons manager tab)."

This is used on the following pages:
about:addons, about:permissions, about:config
http://mxr.mozilla.org/mozilla-central/search?string=disablefastfind

I already fixed about:config by making accel+f focus the search box, but the problem is still visible in about:addons (bug 1195060) and about:permissions (bug 661831): You can press accel+f to open the find bar, which should not be possible.

Comment 3

[Steffen Wilberg]

Bug 967517 claims that this is a regression from 2013-07-07, but I only see this with e10s enabled.

Comment 4

[Steffen Wilberg]

So this was disabled deliberately by bug 862078:

if (!gMultiProcessBrowser ...

} else
  disableFindCommands(false);

http://hg.mozilla.org/mozilla-central/annotate/ba43a48d3c52/browser/base/content/browser.js#l4332

Comment 5

[Chris Peterson [:cpeterson]]

Felipe, do you know who would own this disablefastfind XUL test?

Comment 6

[Chris Peterson [:cpeterson]]

Blake, I see that you touched this test for bug 1055508. This test is disabled for e10s on all desktop platforms. How important is fixing this test?

Comment 8

[Steffen Wilberg]

Note that the code needs fixing here, not the test.
Setting |disablefastfind="true"| has no effect in e10s mode. The code has been explicitly disabled in e10s mode, see comment 4.