1094265 - js1_8_5/extensions/reflect-parse.js jstest fails

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

js1_8_5/extensions/reflect-parse.js:189:10 Error: expected SyntaxError for "for (const x in foo);"

Eric, is this from bug 611388? :)

Comment 1

[Eric Faust [:efaust]]

It sure is! I thought (and checked repeatedly) that I had squelched this error. I spent a bunch of time on that test.

I'll take a look today.

Comment 2

[Eric Faust [:efaust]]

Attachment: Fix

Ok, so I think rebasing burned me, here. What happened was we read one extra token, so never got const bindings here. That's got to be wrong all over.

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8517692 [details] [diff] [review]
Fix

Review of attachment 8517692 [details] [diff] [review]:
-----------------------------------------------------------------

yes, this is a change we want :)

::: js/src/frontend/Parser.cpp
@@ +4587,5 @@
>                      isForDecl = true;
>                      blockObj = StaticBlockObject::create(context);
>                      if (!blockObj)
>                          return null();
> +                    pn1 = variables(constDecl ? PNK_CONST: PNK_LET, nullptr, blockObj,

pre-existing nit: weird spacing in the ternary

Comment 4

[Eric Faust [:efaust]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b49cc4ae0fdd

Comment 5

[Gary [:streetwolf52]]

FYI... This patch along with the Add-on "Self-Destructing Cookies 0.4.7-pre2" causes Fx36 to crash.

Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:36.0) Gecko/20100101 Firefox/36.0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b49cc4ae0fdd

Comment 7

[Jeff Walden [:Waldo]]

(In reply to Gary [:streetwolf] from comment #5)
> FYI... This patch along with the Add-on "Self-Destructing Cookies
> 0.4.7-pre2" causes Fx36 to crash.

File a new bug, please?