Closed Bug 1094296 Opened 9 years ago Closed 9 years ago

devedition theme - windows - Bookmarks toolbar hover state has dark text

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36
Tracking Flags:
Tracking Status
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: Gijs, Assigned: ntim)

References

Details

Attachments

(1 file)

Patch
2.04 KB, patch
bgrins
: review+
MattN
: feedback+
Details | Diff | Splinter Review 
      No description provided.
OS: All → Windows XP
Summary: devedition theme - Bookmarks toolbar hover state has dark text → devedition theme - windows - Bookmarks toolbar hover state has dark text
Is this a problem with dark lw themes as well?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Is this a problem with dark lw themes as well?

No. :-(
Flags: needinfo?(gijskruitbosch+bugs)
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attached patch Patch — — Splinter Review 
This fixes the issue + simplifies the unnecessarily long selectors.
Attachment #8518337 - Flags: review?(MattN+bmo)
Attachment #8518337 - Flags: review?(bgrinstead)
Attachment #8518337 - Flags: review?(MattN+bmo)
Attachment #8518337 - Flags: feedback+
Comment on attachment 8518337 [details] [diff] [review]
Patch

Review of attachment 8518337 [details] [diff] [review]:
-----------------------------------------------------------------

Tested this on osx and ubuntu, confirmed it doesn't mess up hover/open states for toolbarbuttons, and the .subviewbutton selector was left over from when we were also including panels.
Attachment #8518337 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/40e3339da787
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.