1094296 - devedition theme - windows - Bookmarks toolbar hover state has dark text

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Comment 1

[Brian Grinstead [:bgrins]]

Is this a problem with dark lw themes as well?

Comment 2

[:Gijs (he/him)]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> Is this a problem with dark lw themes as well?

No. :-(

Comment 3

[Tim Nguyen :ntim]

Attachment: Patch

This fixes the issue + simplifies the unnecessarily long selectors.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8518337 [details] [diff] [review]
Patch

Review of attachment 8518337 [details] [diff] [review]:
-----------------------------------------------------------------

Tested this on osx and ubuntu, confirmed it doesn't mess up hover/open states for toolbarbuttons, and the .subviewbutton selector was left over from when we were also including panels.

Comment 5

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/40e3339da787

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/40e3339da787

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f426e446b9aa