109432 - missing some MIME symbols in static+meta build

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Chris Waterson]

seawood, since you checked in your changes, I'm getting missing symbols in
libmetamail.so (set LD_BIND_NOW=1 with a static build, you'll see it right away):

/usr/src/seamonkey-clean/static-symbols/dist/bin$ LD_BIND_NOW=1 ./mozilla
ProfileManager : StartApprunner
profileName passed in: waterson
**************************************************
nsNativeComponentLoader:
GetFactory(/usr/src/seamonkey-clean/static-symbols/dist/bin/components/libmeta_mail.so)
Load FAILED with error:
/usr/src/seamonkey-clean/static-symbols/dist/bin/components/libmeta_mail.so:
undefined symbol:
__24nsMimeContentTypeHandlerPCcPFPCcP28contentTypeHandlerInitStruct_P15MimeObjectClass
**************************************************

Comment 1

[Chris Waterson]

This pretty much horks the static build, because mail crashes (more or less)
randomly when reading messages.

Comment 2

[hacker formerly known as [e-mail]]

WFM.  That symbol should be in the mimecthglue_s library which I'm seeing as
being linked into my static+meta build.  You might want to try cleaning the
mailnews/mime/cthandlers/ dir and relink.  When I first landed that patch, I
accidentally made that glue lib shared.  There was about an hr window before
that got fixed.

Build config: --enable-static --disable-shared --enable-static
--enable-meta-components=mail,crypto

/usr/gcc295/bin/g++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall
-Wconversion -Wpointer-arith -Wbad-function-cast -Wcast-align
-Woverloaded-virtual -Wsynth -pedantic -Wno-long-long -pthread -pipe  -DNDEBUG
-DTRIMMED -shared -Wl,-h -Wl,libmeta_mail.so -o libmeta_mail.so 
nsMetaModule_mail.o    -Wl,--whole-archive 
../../dist/lib/components/libmailnews.a  ../../dist/lib/components/libmsgimap.a
 ../../dist/lib/components/libmime.a  ../../dist/lib/components/libmimeemitter.a
 ../../dist/lib/components/libmsgnews.a 
../../dist/lib/components/libmsgcompose.a 
../../dist/lib/components/liblocalmail.a 
../../dist/lib/components/libabsyncsvc.a  ../../dist/lib/components/libimport.a
 ../../dist/lib/components/libaddrbook.a  ../../dist/lib/components/libimpText.a
 ../../dist/lib/components/libvcard.a  ../../dist/lib/components/libmsgdb.a 
../../dist/lib/components/libsmimestb.a  ../../dist/lib/libmsgbaseutil.a 
../../dist/lib/libmimecthglue_s.a -Wl,--no-whole-archive  -Wl,--version-script
-Wl,../../../mozilla/build/unix/gnu-ld-scripts/components-version-script -ldl
-lm  -lc   

Comment 3

[hacker formerly known as [e-mail]]

Nevermind. I'm a dork.  I forgot that I had a patch in this tree for the meta
rules in config.mk.

Comment 4

[hacker formerly known as [e-mail]]

Attachment: Update META_COMPONENT entires for mail

Comment 5

[Chris Waterson]

Comment on attachment 57322 [details] [diff] [review]
Update META_COMPONENT entires for mail

sr=waterson

Comment 6

[Chris Waterson]

Oops, maybe I spoke to soon:

c++ -o nsMetaModule_mail.o -c -DOSTYPE=\"Linux2.4\" -DOSARCH=\"Linux\" -DOJI
-DMETA_MODULE=\"meta_mail\" -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT
-I../../../mozilla/modules/staticmod -I../../dist/include/xpcom
-I../../dist/include -I../../dist/include
-I/usr/src/seamonkey-clean/static/dist/include/nspr  -I/usr/lib/include
-I/usr/lib/include  -I/usr/lib/include -I/usr/X11R6/include   -fPIC 
-I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth
-pedantic -Wno-long-long -Wno-format -fshort-wchar -pthread -O2 -pipe  -DNDEBUG
-DTRIMMED -I/usr/X11R6/include -DMOZILLA_CLIENT -include ../../config-defs.h
-Wp,-MD,.deps/nsMetaModule_mail.pp nsMetaModule_mail.cpp
make[2]: *** No rule to make target `../../dist/lib/components/libsmimestb.a',
needed by `libmeta_mail.so'.  Stop.
make[2]: Leaving directory `/usr/src/seamonkey-clean/static/modules/staticmod'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/src/seamonkey-clean/static/modules/staticmod'
make: *** [install] Error 2

Comment 7

[hacker formerly known as [e-mail]]

Attachment: Same patch for the trunk

Patch needed to be redone for the trunk since smime landed

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 57533 [details] [diff] [review]
Same patch for the trunk

r=bryner

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 57322 [details] [diff] [review]
Update META_COMPONENT entires for mail

a=blizzard on behalf of drivers for 0.9.6

Comment 10

[hacker formerly known as [e-mail]]

attachment 57322 [details] [diff] [review] has been checked into the 0.9.6 branch.
attachment 57533 [details] [diff] [review] has been checked into the trunk.

Comment 11

[Sheela Ravindran]

Reassign to stephend

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

3.207 seawood%netscape.com Nov 12 23:48   Update mail meta modules list to 
handle smime.
Bug #109432 r=bryner

I'm assuming that this works for everybody (Waterson, if not, please re-open).  

Verified FIXED.

Comment 13

[Chris Waterson]

WFM, yay! Thanks.