1094429 - JavaScript strict warning: chrome://browser/content/sanitize.js, line 74: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Start a debug build.
 2. Inspect the first few lines of output.

ACTUAL RESULTS:
This appears in the output:
{
JavaScript strict warning: chrome://browser/content/sanitize.js, line 74: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function
}

This seems to be for the function "onWindowsCleaned":
> 58   sanitize: function (aItemsToClear)
> 59   {
> 60     var deferred = Promise.defer();
[...]
> 77       function onWindowsCleaned() {
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js?rev=7c582981a0b0#77

This function was just added last week in bug 1088137:
 https://hg.mozilla.org/mozilla-central/rev/61cbd994f800

dolske, can we refactor this such that it doesn't spam a startup JS warning?

Comment 1

[:Gijs (he/him)]

Attachment: fix strict warning in sanitize.js,

Comment 2

[:Gijs (he/him)]

https://hg.mozilla.org/integration/fx-team/rev/347c76e80e6f

Marco, can you add this?

Comment 3

[Marco Mucci [:MarcoM]]

Added to IT 36.2

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/347c76e80e6f