1094505 - Avoid using concatenated name in installer

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Attachment: 2014-11-04_1336.png

See screenshot, it would be great if the installer displayed 'Firefox Developer Edition' instead of 'FirefoxDeveloperEdition'.

Comment 1

[Brian Grinstead [:bgrins]]

You probably meant this to block fx-dev-edition

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Avoid using concatenated name in installer

I think this should work, assuming branding.nsi overrides defines.nsi.in. I want to push it on Gum to verify, but we decided to no longer treat Gum as our try server, so asking for review first.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Avoid using concatenated name in installer v2

Turns out you can't define something twice. Who knew?

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/15d3dc8c5b63

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15d3dc8c5b63

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8519253 [details] [diff] [review]
Avoid using concatenated name in installer v2

Approval Request Comment
[Feature/regressing bug #]: Developer Edition feature, but the concatenated strings were introduced in bug 1072181 and bug 1090324
[User impact if declined]: users will see an ugly browser name in some parts of the Windows installer
[Describe test coverage new/current, TBPL]: manual testing on try
[Risks and why]: practically zero risk, as it's just a string change
[String/UUID change made/needed]: a string was changed to a value that is already present, but it's not even one that is localized as far as I know

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f76be16501c9