1094521 - archivereader.obj gets rebuilt after profiling run

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[(Away)]

This prevents me from getting rid of the 'PGUPDATE' hack in configure.in. Glandium says it's due to the makefile rules in bug 902761.

9:27.40 archivereader.obj
 9:27.40 s:/inbound/obj/pgo/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  cl -Foarchivereader.obj -c   -DUNICODE -D_UNICODE -DNOMINMAX -DNS_NO_XPCOM -DMAR_CHANNEL_ID='"firefox-mozilla-central"' -DMOZ_APP_VERSION='"36.0a1"' -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -Is:/inbound/toolkit/mozapps/update/updater -I. -Is:/inbound/toolkit/xre -Is:/inbound/toolkit/mozapps/update/updater/../common -Is:/inbound/xpcom/glue -I../../../../dist/include   -Is:/inbound/obj/pgo/dist/include/nspr -Is:/inbound/obj/pgo/dist/include/nss        -MT            -FI ../../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -O1 -Oi -Oy    -Fdgenerated.pdb   s:/inbound/toolkit/mozapps/update/updater/archivereader.cpp
9:28.04 archivereader.cpp
9:30.39 updater.exe
9:30.40 s:/inbound/obj/pgo/_virtualenv/Scripts/python.exe s:/inbound/config/expandlibs_exec.py --uselist -- link -NOLOGO -OUT:updater.exe -PDB:updater.pdb -ENTRY:wmainCRTStartup -SUBSYSTEM:WINDOWS,5.01 -LARGEADDRESSAWARE -NXCOMPAT -DYNAMICBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF -LTCG:PGINSTRUMENT -DELAYLOAD:crypt32.dll -DELAYLOAD:userenv.dll -DELAYLOAD:wsock32.dll     archivereader.obj bspatch.obj updater.obj loaddlls.obj progressui_win.obj win_dirent.obj ./module.res ../../../../toolkit/mozapps/update/common-standalone/updatecommon-standalone.lib ../../../../modules/libmar/verify/verifymar.lib ../../../../modules/libmar/src/mar.lib ../../../../modules/libbz2/src/bz2.lib   kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib comctl32.lib ws2_32.lib shell32.lib shlwapi.lib crypt32.lib advapi32.lib delayimp.lib
 
44:24.86 archivereader.obj
44:24.86 s:/inbound/obj/pgo/_virtualenv/Scripts/python.exe -m mozbuild.action.cl  cl -Foarchivereader.obj -c   -DUNICODE -D_UNICODE -DNOMINMAX -DNS_NO_XPCOM -DMAR_CHANNEL_ID='"firefox-mozilla-central"' -DMOZ_APP_VERSION='"36.0a1"' -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -Is:/inbound/toolkit/mozapps/update/updater -I. -Is:/inbound/toolkit/xre -Is:/inbound/toolkit/mozapps/update/updater/../common -Is:/inbound/xpcom/glue -I../../../../dist/include   -Is:/inbound/obj/pgo/dist/include/nspr -Is:/inbound/obj/pgo/dist/include/nss        -MT            -FI ../../../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -O1 -Oi -Oy    -Fdgenerated.pdb   s:/inbound/toolkit/mozapps/update/updater/archivereader.cpp
 
44:25.73 archivereader.cpp
44:25.74 updater.exe
44:25.76 s:/inbound/obj/pgo/_virtualenv/Scripts/python.exe s:/inbound/config/expandlibs_exec.py --uselist -- link -NOLOGO -OUT:updater.exe -PDB:updater.pdb -ENTRY:wmainCRTStartup -SUBSYSTEM:WINDOWS,5.01 -LARGEADDRESSAWARE -NXCOMPAT -DYNAMICBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV -DEBUG -OPT:REF -LTCG:PGOPTIMIZE -DELAYLOAD:crypt32.dll -DELAYLOAD:userenv.dll -DELAYLOAD:wsock32.dll     archivereader.obj bspatch.obj updater.obj loaddlls.obj progressui_win.obj win_dirent.obj ./module.res ../../../../toolkit/mozapps/update/common-standalone/updatecommon-standalone.lib ../../../../modules/libmar/verify/verifymar.lib ../../../../modules/libmar/src/mar.lib ../../../../modules/libbz2/src/bz2.lib   kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib netapi32.lib comctl32.lib ws2_32.lib shell32.lib shlwapi.lib crypt32.lib advapi32.lib delayimp.lib
 
44:26.06 archivereader.obj : fatal error LNK1270: invalid file; timestamp does not match file linked with /LTCG:PGINSTRUMENT

Comment 1

[Mike Hommey [:glandium]]

Attachment: Rewrite export rules in toolkit/mozapps/update/updater/Makefile.in to not regenerate files every time

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cfd7d00e994

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5cfd7d00e994