1094526 - [mozlog] xpcshell-test PROCESS_OUTPUT contains extra newlines

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: t.patch

If you run xpcshell tests that generate "process output", the output looks like:

0:01.27 PROCESS_OUTPUT: Thread-1 (pid:13600) "1415236493351	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider"]
"
 0:01.27 PROCESS_OUTPUT: Thread-1 (pid:13600) "1415236493351	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]
"

(which might be hard to see if bugzilla wraps the line, but each output line looks like '... "an output line\n"\n' - ie, every line of output includes the raw \n (\r\n on Windows) character from the process output, then a close quote and additional \n added by the test harness.

With the following patch applied the output becomes:

0:01.24 PROCESS_OUTPUT: Thread-1 (pid:15216) "1415236662103	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider"]"
 0:01.24 PROCESS_OUTPUT: Thread-1 (pid:15216) "1415236662103	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]"

Chris, does this patch make sense, or should it be handled elsewhere?

(In-fact, I'd prefer to see it look something like:
0:01.24 PROCESS_OUTPUT: Thread-1 (pid:15216):   141523....

(ie, a ':\t' instead of the open quote and no closing quote, but that might be more controversial)

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8517834 [details] [diff] [review]
t.patch

Review of attachment 8517834 [details] [diff] [review]:
-----------------------------------------------------------------

I'm all for it, but I think I'd err on the side of doing this in the producer, somewhere around http://hg.mozilla.org/mozilla-central/file/2114ef80f6ae/testing/xpcshell/runxpcshelltests.py#l492

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0005-Bug-1094526-remove-extra-n-chars-from-xpcshell-test-.patch

SGTM!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f79e13de65b0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f79e13de65b0