1094549 - MediaCacheStream::Read get stuck when stream length is zero

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

1. MediaCacheStream::Read is called when mStreamLength is -1
2. It waits for data at http://hg.mozilla.org/mozilla-central/file/72ae882fce1a/dom/media/MediaCache.cpp#l2232
3. MediaCacheStream::NotifyDataEnded is called for download is finished.
4. MediaCacheStream::FlushPartialBlockInternal(true) is called by MediaCacheStream::NotifyDataEnded.
5. FlushPartialBlockInternal doesn't notify the readers for blockOffset is 0
6. MediaCacheStream::Read waits for data to come endlessly.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1094549_part1_test_case.patch

An error event should fire when decoding a zero-length file for decoding metadata will fail. It tests if MediaCacheStream::Read() gets stuck in waiting for data that will never come.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1094549_part2_fix_MediaCacheStream_Read_hang.patch

MediaCacheStream::FlushPartialBlockInternal should notify all readers even when channel offset is zero.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=c475631db540
Most green.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8518175 [details] [diff] [review]
1094549_part2_fix_MediaCacheStream_Read_hang.patch

Review of attachment 8518175 [details] [diff] [review]:
-----------------------------------------------------------------

Good work!

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aad9ef4320b8
https://hg.mozilla.org/integration/mozilla-inbound/rev/88c90de8b7c6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aad9ef4320b8
https://hg.mozilla.org/mozilla-central/rev/88c90de8b7c6